allow agent to run compound tasks #261347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Aug 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enables agents to run compound tasks by adding support for handling task dependencies. The changes allow the task execution tools to resolve and track multiple terminals when running tasks that have dependencies.
Key changes:
- Added support for resolving task dependencies and handling multiple terminals
- Updated task execution tools to track output from all related terminals
- Modified the task service API to handle multiple tasks/terminals instead of single instances
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
runTaskTool.ts |
Updated to resolve dependency tasks and handle multiple terminals for compound task execution |
getTaskOutputTool.ts |
Modified to get output from all terminals associated with a task and its dependencies |
createAndRunTaskTool.ts |
Enhanced to track multiple terminals and aggregate results from compound tasks |
taskHelpers.ts |
Added resolveDependencyTasks function and updated getTaskForTool to support parent tasks |
taskSystem.ts |
Changed interface from single terminal to multiple terminals support |
taskService.ts |
Updated service interface to handle arrays of tasks/terminals |
terminalTaskSystem.ts |
Implemented logic to return multiple terminal resources for task arrays |
abstractTaskService.ts |
Updated to delegate to new multi-terminal API |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/taskHelpers.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/runTaskTool.ts
Outdated
Show resolved
Hide resolved
.../workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/createAndRunTaskTool.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DonJayamanne
previously approved these changes
Aug 13, 2025
Tyriar
previously requested changes
Aug 13, 2025
.../workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/createAndRunTaskTool.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/getTaskOutputTool.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/getTaskOutputTool.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Tyriar
previously approved these changes
Aug 13, 2025
demo.mov |
alexr00
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #258241
Screen.Recording.2025-08-12.at.6.17.19.PM.mov