Set triggerCommandOnProviderChange default to false to fix #256458 #258171
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hediet <2931520+hediet@users.noreply.github.com>
Copilot finished work on behalf of
hediet
July 28, 2025 09:52
hediet
approved these changes
Jul 28, 2025
aiday-mar
approved these changes
Jul 28, 2025
aiday-mar
approved these changes
Jul 28, 2025
lszomoru
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default value of
editor.inlineSuggest.experimental.triggerCommandOnProviderChangefromtruetofalseto adopt the NES (Notebook Extension Server) provider onchange event as the default behavior.Background
The
triggerCommandOnProviderChangesetting controls whether to trigger a command when the inline suggestion provider changes. Based on experimental data showing no significant performance impact, we're now making the "onchange event" behavior the default.Changes
src/vs/editor/common/config/editorOptions.tsfromtruetofalseImpact
With this change, when an inline completion provider changes, the code will now:
This aligns with the existing TODO comment in the codebase that suggests "remove this and always do the else branch", making the intended behavior the default.
Fixes #256458
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.orgnode-gyp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.