Skip to content

Merge allow and deny lists into autoApprove #256725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2025
Merged

Merge allow and deny lists into autoApprove #256725

merged 5 commits into from
Jul 18, 2025

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 18, 2025 •
edited
Loading

Fixes #253472

This change merges chat.agent.terminal.allowList and chat.agent.terminal.denyList into chat.agent.terminal.autoApprove. It works basically the same, just the deny list entries are now false.

Before:

"chat.agent.terminal.allowList": {
  "foo": true,
},
"chat.agent.terminal.denyList": {
  "bar": true,
  "rm": false,
},

After:

"chat.agent.terminal.autoApprove": {
  "foo": true,
  "bar": false,
  "rm": null, // unset via null
},

@Tyriar Tyriar added this to the July 2025 milestone Jul 18, 2025
@Tyriar Tyriar self-assigned this Jul 18, 2025
@Tyriar Tyriar marked this pull request as ready for review July 18, 2025 17:51
@Tyriar Tyriar requested a review from meganrogge July 18, 2025 17:51
@Tyriar Tyriar mentioned this pull request Jul 18, 2025
Merged
@Tyriar Tyriar merged commit cc1d86c into main Jul 18, 2025
18 checks passed
@Tyriar Tyriar deleted the tyriar/autoapprove_merge branch July 18, 2025 18:20
@Tyriar Tyriar mentioned this pull request Jul 23, 2025
Closed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
July 2025
Development

Successfully merging this pull request may close these issues.

Merge allowList and denyList settings together now that they're objects
2 participants
@Tyriar @meganrogge