Skip to content

Revert "chat - begin installation earlier (#252925)" #254961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Revert "chat - begin installation earlier (#252925)" #254961

merged 1 commit into from
Jul 9, 2025

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jul 9, 2025 •
edited
Loading

Fix #254968

This reverts commit 4e32b01.

@bpasero bpasero self-assigned this Jul 9, 2025
@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Jul 9, 2025
@bpasero bpasero added this to the June 2025 milestone Jul 9, 2025
@bpasero bpasero requested a review from roblourens July 9, 2025 20:10
@bpasero bpasero mentioned this pull request Jul 9, 2025
Closed
@bpasero bpasero enabled auto-merge (squash) July 9, 2025 20:37
roblourens
roblourens approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. It's a straightforward revert, the logic is easy to follow, it's going back to the way it worked previously

@joshspicer joshspicer disabled auto-merge July 9, 2025 21:30
@joshspicer joshspicer enabled auto-merge (squash) July 9, 2025 21:30
@joshspicer joshspicer closed this Jul 9, 2025
auto-merge was automatically disabled July 9, 2025 21:31

Pull request was closed

@joshspicer joshspicer reopened this Jul 9, 2025
@joshspicer joshspicer enabled auto-merge (squash) July 9, 2025 21:31
@joshspicer joshspicer disabled auto-merge July 9, 2025 22:00
@joshspicer joshspicer enabled auto-merge (squash) July 9, 2025 22:00
@joshspicer joshspicer merged commit cb0c47c into release/1.102 Jul 9, 2025
12 checks passed
@joshspicer joshspicer deleted the ben/ultimate-barnacle branch July 9, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

@joshspicer joshspicer joshspicer approved these changes

Assignees

@bpasero bpasero

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
June 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@bpasero @roblourens @joshspicer