Fixes #242059 #250833
Merged
Fixes #242059 #250833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszomoru
approved these changes
Jun 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242059 FYI @jrieken
The position cannot be wrong now anymore, as only "well behaving" observables are read. "Well behaving" observables ensure that dependencies always see globally consistent state.
The observableFromEvent was not well-behaving, as the text model change event fires (immediately triggering reactions) before other objects can update their data. This could cause the autorun to see inconsistent state.
editorObs.versionIduses editor transactions to avoid this problem.