-
Notifications
You must be signed in to change notification settings - Fork 34.9k
Warn about installed extensions that are no longer available in Marketplace #248852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandy081
reviewed
May 16, 2025
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
Outdated
Show resolved
Hide resolved
82cc563
to
322c19e
Compare
sandy081
requested changes
May 30, 2025
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
Outdated
Show resolved
Hide resolved
…bsets of a galleryExtension
b216502
to
91de671
Compare
sandy081
requested changes
Jun 2, 2025
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
Outdated
Show resolved
Hide resolved
sandy081
previously approved these changes
Jun 2, 2025
Approving given that
Edit: No need to create a follow up item for above scenario, this will be a limitation for those users who has auto update check disabled. Which means we do not detect missing extensions in this case. We can add this as a Note. |
Tyriar
approved these changes
Jun 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #181248
Indicator when an installed extension (whose source is
gallery
) can no longer be resolved from the marketplace.Piggybacks on
ExtensionsWorkbenchService::checkForUpdates()
, similar to how the verified badge and other gallery metadata is pulled.pulled.mov