Skip to content

git: make Letter/Text/Color semantically consistency #245889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

git: make Letter/Text/Color semantically consistency #245889

merged 2 commits into from
Apr 15, 2025

Conversation

Cecil0o0
Copy link
Contributor

@Cecil0o0 Cecil0o0 commented Apr 7, 2025 •
edited
Loading

In Git extension, there is an ambiguous code snippet about semantic in a switch-case syntax among getStatusLetter, getStatusText and getStatusColor static methods.

In a version control system, it may be correct if DELETED_BY_THEM status represents a conflict rather than a NORMAL OPERATION, as the l10n code explicitly describes:

...
case Status.DELETED_BY_THEM: return l10n.t('Conflict: Deleted By Them');
...

This fix would like to eliminate semantic ambiguity

@lszomoru
Copy link
Member

lszomoru commented Apr 7, 2025

@Cecil0o0, thank you very much for the contribution.
Could you please file an issue in which you are describing the issue that you are trying to address with these changes?

@Cecil0o0
Copy link
Contributor Author

Cecil0o0 commented Apr 8, 2025 •
edited
Loading

@lszomoru of course, here is a new filed issue #245993. Please have a look for my description, if something unclear please let know!

@Cecil0o0
Copy link
Contributor Author

@Cecil0o0, thank you very much for the contribution. Could you please file an issue in which you are describing the issue that you are trying to address with these changes?

@lszomoru hi, could you please have a look for this one~

@lszomoru lszomoru enabled auto-merge (squash) April 15, 2025 08:16
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 15, 2025
@lszomoru lszomoru merged commit 541ae30 into microsoft:main Apr 15, 2025
7 checks passed
@Cecil0o0 Cecil0o0 deleted the combine_conditions branch April 15, 2025 09:12
@lszomoru
Copy link
Member

@Cecil0o0, thank you very much for your contribution.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lszomoru lszomoru lszomoru approved these changes

@chrmarti chrmarti chrmarti approved these changes

Assignees

@lszomoru lszomoru

Labels
None yet
Projects
None yet
Milestone
April 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@Cecil0o0 @lszomoru @chrmarti