Skip to content

chore: update to Electron 35 #245423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
May 9, 2025
Merged

chore: update to Electron 35 #245423

merged 27 commits into from
May 9, 2025

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Apr 3, 2025 •
edited
Loading

Fixes #245420
Fixes #230303
Fixes #247054

@deepak1556 deepak1556 added this to the April 2025 milestone Apr 3, 2025
@deepak1556 deepak1556 self-assigned this Apr 3, 2025
@mkurz
Copy link

mkurz commented Apr 8, 2025

https://releases.electronjs.org/release/v35.1.4 out already.

@tats-u tats-u mentioned this pull request Apr 9, 2025
Open
@deepak1556 deepak1556 force-pushed the electron-35.x.y branch 2 times, most recently from 59ddd1d to 543e035 Compare April 11, 2025 04:20
@CHC383 CHC383 mentioned this pull request Apr 14, 2025
Open
@deepak1556 deepak1556 force-pushed the electron-35.x.y branch 6 times, most recently from e865a77 to f384038 Compare April 18, 2025 12:23
@mkurz
Copy link

mkurz commented Apr 18, 2025

Electron 35.2.0 out now: https://releases.electronjs.org/release/v35.2.0

@deepak1556 deepak1556 force-pushed the electron-35.x.y branch 3 times, most recently from 2b69e4d to 3bb1edf Compare April 22, 2025 06:18
mkurz
mkurz reviewed Apr 22, 2025
View reviewed changes
mkurz
mkurz reviewed Apr 23, 2025
View reviewed changes
@deepak1556 deepak1556 modified the milestones: April 2025, May 2025 Apr 25, 2025
@deepak1556 deepak1556 force-pushed the electron-35.x.y branch 2 times, most recently from a4a1e7f to ec6b550 Compare May 5, 2025 12:33
@deepak1556 deepak1556 mentioned this pull request May 5, 2025
Open
@flying-sheep
Copy link

Will this fix #53812?

@flying-sheep flying-sheep mentioned this pull request May 6, 2025
Closed
@deepak1556
Copy link
Collaborator Author

VSCode doesn't control the position of window controls, the runtime (Electron) draws it and there is currently no option to control the position. So this PR will not address #53812

@flying-sheep
Copy link

the runtime (Electron) draws it and there is currently no option to control the position

Yeah, I know. I just had in my mind that either Electron 35 or 36 was the version that finally fixes that.

But seems like this isn’t fixed in any of them: electron/electron#44540

Sorry for the noise

deepak1556 and others added 18 commits May 9, 2025 15:04
@deepak1556
ci: enable timeout for smoketests
21669cf
@deepak1556
chore: bump min glibcxx to 3.4.26 for server
b97ed83
@deepak1556
Revert "ci: enable timeout for smoketests"
f930bae 
This reverts commit afb637e.
@deepak1556
chore: update debian dependencies
09d3e90
@deepak1556
fix: workaround npm.ps1 argument parsing with powershell
0883e16
@deepak1556
chore: update rpm dependencies
8783cbe
@deepak1556
test: partially revert changes from 242535
758e381
@deepak1556
test: remove redudant keybinding dispatch for selectTab
effc4f2
@deepak1556
test: fix test failure from running configured tasks
e884621
@deepak1556
test: focus settings editor for preferences.test.ts
35bbce3
@bpasero @deepak1556
node - adopt compile cache (#246835)
59aa2ba 
* node - adopt compile cache

* adopt for utility process

* tweaks
@bpasero @deepak1556
log state of compilation cache
e8d0d1e
@deepak1556
Revert "log state of compilation cache"
79d81b2 
This reverts commit f384038.
@deepak1556
Revert "node - adopt compile cache (#246835)"
02e1d6d 
This reverts commit 673a00c.
@deepak1556
chore: update builds
cd403f1
@deepak1556
chore: bump electron@35.2.0
3243550
@deepak1556
chore: bump electron@35.2.1
b940cd8
@deepak1556
chore: bump electron@35.2.2
58746d0
@deepak1556 deepak1556 requested a review from bpasero May 9, 2025 09:18
@deepak1556 deepak1556 marked this pull request as ready for review May 9, 2025 09:19
@deepak1556 deepak1556 merged commit 12326f9 into main May 9, 2025
35 checks passed
@deepak1556 deepak1556 deleted the electron-35.x.y branch May 9, 2025 10:03
This was referenced May 9, 2025
Merged
Closed
@benz0li benz0li mentioned this pull request May 25, 2025
Closed
@oc109 oc109 mentioned this pull request Jun 1, 2025
Open
meganrogge added a commit that referenced this pull request Jun 5, 2025
@meganrogge
Revert "chore: update to Electron 35 (#245423)"
b1523a1 
This reverts commit 12326f9.
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

+1 more reviewer

@mkurz mkurz mkurz left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
May 2025
Development

Successfully merging this pull request may close these issues.

broken window border with wayland Electron 35 update VS Code crashes with reconversion from google IME input
4 participants
@deepak1556 @mkurz @flying-sheep @bpasero