Fix line comment action for makefiles (Fixes #234464) #243283

Enzo-Nunes · 2025-03-12T00:05:46Z

This pull request addresses an old bug (issue #234464) where the line comment action in VS Code failed to correctly handle makefiles. By default, VS Code uses Ctrl + / to comment lines, but for makefiles, comment tokens must be placed in the first column to avoid being just forwarded to the shell.

The issue happened because the line comment action didn't account for the language being edited. This fix passes the languageId to the comment function, allowing it to handle makefiles differently. A new test has been added to verify this functionality.

To test this in practice, open any makefile and try using the keybind Ctrl + / on an indented line of code, with and without my fix. You will notice the different placement of the comment token.

Enzo-Nunes · 2025-03-12T10:08:52Z

@microsoft-github-policy-service agree

src/vs/editor/contrib/comment/browser/lineCommentCommand.ts

Namiland · 2025-03-15T02:10:58Z

Hi

Enzo-Nunes · 2025-03-15T02:18:41Z

@hediet Hello! I see you are now assigned to this PR. A colleague of yours requested some changes and I've worked on a fix which I just published. You might want to take a look at that. :)

Enzo-Nunes · 2025-03-24T09:38:57Z

@hediet @aeschli Has any of you had any time to take a look? If you need me to review anything, refactor code or either rebase or merge my branch, let me know.

hediet · 2025-03-24T11:06:34Z

Thanks for the PR!
Two things: Columns are generally 1 based in VS Code.
Also, I doubt a different value than 1 would ever make sense for lineCommentTokenColumn, so I think that property should be refactored into a boolean.

Are you sure there is no way to do that with existing functionality? E.g. a regexp that matches the \n character? @aiday-mar might know more here

Enzo-Nunes · 2025-03-24T11:26:13Z

@hediet Thank you for the response. I agree! A boolean value would much probably be enough, I'll refactor that and add a commit.

Also, I've taken a good look at the source code which handles this kind of line comment action, and I don't see a more optimal way of accomplishing this with already existing functionality. You mentioned using a regexp that matches '\n', but I don't see how that would be useful to address the issue. Could you clarify a little further?

@aiday-mar any help is welcome, of course. :)

hediet · 2025-03-24T11:37:24Z

Could you clarify a little further?

I'm not very familiar with this code, but I remember other situations where that helped. Could be very well that it doesn't apply here!

Enzo-Nunes · 2025-03-24T11:49:46Z

I understand. Out of my head I don't think that would help address this case, but I'll take another look regardless. I'll post a commit once the code is refactored.

aiday-mar · 2025-03-24T12:30:37Z

Hi @Enzo-Nunes thanks for the PR. I see you added a new field to the language configuration file called the lineCommentTokenColumn to define a custom value for the index at which to insert the comment. I wonder if we should be introducing such a field as this is makefile specific? I wonder if there are other languages that require comment insertion at a specific index? Letting @aeschli comment here

Enzo-Nunes · 2025-03-24T12:51:46Z

@aiday-mar Hello! Although this is makefile specific, @aeschli instructed me to not to hard code "makefile" into the line comment action code. As such, I've changed the fix to solve the issue through the language configuration service with that new lineCommentTokenColumn field.

While this means that this new field becomes available to every language, its usage is completely optional. The only place where this value is indeed set is in the language-configration.json of makefiles. This solution addresses the issue for makefiles and can also be used by other languages by changing their own configuration files to include this new field.

As @hediet suggested, I'll be refactoring the fix to only include a boolean value which indicates if the comment token should be placed adjacent to the leftmost column or not, resulting in an even simpler solution. I'll publish a commit later today.

Enzo-Nunes · 2025-03-24T19:41:19Z

@hediet I've refactored the fix into a boolean value, as requested. Also, you mentioned columns are 1 based, but since we're no longer using a number I assume that's not a problem anymore.

Let me know if you want any more changes to be made or if it's time to rebase.

RedCMD · 2025-03-24T19:47:43Z

I doubt a different value than 1 would ever make sense for lineCommentTokenColumn, so I think that property should be refactored into a boolean.

@hediet @aiday-mar

the language here requires the comment token to be in the 2nd column
microsoft/vscode-discussions#2363
it may work if the comment token is set to " #"

@Enzo-Nunes can you test if setting the comment token to ' #' results in ctrl+/ continuing to work correctly?
(with # in the 2nd column)

Enzo-Nunes · 2025-03-24T21:20:34Z

@Enzo-Nunes can you test if setting the comment token to ' #' results in ctrl+/ continuing to work correctly? (with # in the 2nd column)

It does! If you set the field lineCommentTokenFirstColumn to 'true' and set the comment token to something like ' #', it toggles comments correctly while placing the comment token on the 2nd column.

Enzo-Nunes · 2025-03-31T16:38:46Z

@aeschli @hediet have you guys had the time to take a look? Do you agree with the solution?

aiday-mar · 2025-04-16T08:33:23Z

Hi @Enzo-Nunes Thank you for the ping. I will discuss this idea with my team. I am not sure if we should be modifying the language configuration file schema to support this case. I will let you know what we discuss.

Enzo-Nunes · 2025-04-16T09:01:16Z

Alright! I'll be waiting. Thank you for your support.

aiday-mar · 2025-05-07T08:54:21Z

Hi @Enzo-Nunes thanks for the PR. I have not yet received word from my colleagues. I will bring it up this week or next in a meeting.

Enzo-Nunes · 2025-05-08T14:44:48Z

Thank you very much for the attention! I'll be waiting for new developments.

aiday-mar · 2025-06-02T08:58:00Z

Hi @Enzo-Nunes yes apologies. I discussed this PR with my colleagues and they suggested the following. Perhaps we should change the field:

lineComment?: string | null;
to :

lineComment?: string | { comment: string; noIndent?: boolean } | null

This way we do not add a new field but extend the existing field so it can also be of type object that takes as an option the noIndent boolean. This boolean should by default be false. To make this cleaner, I would extract the object type into a separate interface.

Enzo-Nunes · 2025-06-02T09:45:40Z

Alright! I'll make those changes and get back to you.

Pass languageId to _analyzeLines to distinguish makefiles from the rest of the languages. Add test to _analyzeLines specifically for makefiles.

…dd comment rule to specify fixed column token placement. Change test scope to test line command instead of just testing the _analyzeLines method.

…isting logic for new config format.

Enzo-Nunes · 2025-06-02T11:27:09Z

@aiday-mar I've applied the changes you requested and the code looks even cleaner now!

I've also had to update the branch so everything compiled correctly on my end, so I had to force-push the rebase.

If there is anything else you want changed or clarified, let me know.

Thank you!

aiday-mar · 2025-06-05T09:17:33Z

Hi @Enzo-Nunes thanks for the consistent work! I will have a look.

aiday-mar · 2025-06-05T09:33:05Z

Hi @Enzo-Nunes I have had a look and will push some minor polish changes which do not change the logic. I will put an approval but I think we should merge this next week. This week we are preparing our next release and only critical changes are going into the code base.

Enzo-Nunes · 2025-06-05T09:37:07Z

@aiday-mar Alright, I understand. Thank you very much for the time and assistance. :)

sandy081 · 2025-06-05T09:43:42Z

@aiday-mar I see this is a contribution from the community and since we are in endgame week, is this required to be fixed, given that the bug it is fixing is in backlog and old

Edit: Ok, I see it is planned for June and Auto merge is disabled. I came across this in the code-review channel and therefore raised the flag.

aiday-mar · 2025-06-05T09:56:07Z

Hi @sandy081 yep, I plan to merge this next week during debt week

Dismissing after reviewing again

@bpasero

* Apply `font-variation-settings` to `suggestWidgetRenderer` * fix patternIndices typo * Import type from xterm/headless Fixes microsoft#248589 * Commented out settings slide * Progress button on last step now says 'Start coding' instead of 'Next' * Update VS Code intro walkthrough final button labels * Update other references * Tiny changes to input hover bar ('x' button) to match code block toolbar (microsoft#250566) Co-authored-by: Joanna Oikawa <joannaoikawa@Joannas-MacBook-Pro.local> * ensure state is modified on any edit applied from the agent (microsoft#250567) * commands: fix potential issue on vscode.dev/edu route (microsoft#250573) Closes microsoft/vscode-dev#1290 * Use Loopback as default _with_ redirect (microsoft#250570) To have the best chance of working. ref microsoft#250547 * redo borders for chat bubbles + hover fixes (microsoft#250569) * some fixes * add back border, fixes arrows up and down * watcher - polish log output (microsoft#250586) * chat - increase timeout for setup waiting when connected to a remote (microsoft#250587) * fix focus on attachments and render attachments (microsoft#250578) * fix render attachments * clean up * chat - add logos to continue buttons (microsoft#250391) * chat - add logos to continue buttons * . * polish toolset schemas (microsoft#250592) fixes microsoft#250417 fixes microsoft#250483 * fix microsoft#250482 (microsoft#250593) * Don't show title in custom title bar if shown in native title bar (microsoft#250596) dont show title in custom title bar if shown in native title bar * Improve gutter menu rendering when no line numbers (microsoft#250597) improve gutter menu rendering when no line numbers * Tools picker updates (microsoft#250600) * use gear-icon for `Configure Tool Sets...` command * sort tools/tool-sets in picker microsoft#250476 * fix microsoft#249863 - Timeout manifest request (microsoft#250601) * Chat does not register agent again when extension re-installed (fix microsoft#250382) (microsoft#250551) * chat - no need to duplicate SVGs (microsoft#250602) The build process will move them to the top level `media` folder * Align "Configure Tool Sets" command (microsoft#250605) * add to view menu * change wording to "Create new..." * ellipsis in title microsoft#250474 * chat - continue installation independent of sign-in result (microsoft#250606) * PLG: Guide users to continue or finish setup (microsoft/vscode-copilot#16775) (microsoft#250614) * Review usages of `EditorOption.lineHeight` (microsoft#248794) (microsoft#250625) * Dropdown / Select Box should follow `window.menuStyle` (microsoft#250627) Dropdown / Select Box should follow `window.menuSytle` * Browser popup block is obtrusive when refreshing the page with the process explorer open (fix microsoft#250469) (microsoft#250618) * Browser popup block is obtrusive when refreshing the page with the process explorer open (fix microsoft#250469) * fix ci * fix ci * windows - for now show OS context menu in title (workaround microsoft#250626) (microsoft#250631) * Use `y` and `n` keybindings for keep- and undo-changes. (microsoft#250635) fixes microsoft#248041 (comment) * Fix enum order for menu style (microsoft#250387) fix enum order for menu style * Use Copilot instead of Chat for action title (microsoft#250641) Use Copilot instead of Chat * Auto-generated baselines by 1ES Pipeline Templates (microsoft#250340) Updated for https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build?definitionId=111 by using baselines generated in https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=340919 Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> * don't hardcode Copilot name (microsoft#250645) * only apply graceful kill setting to linux/macOS (microsoft#250639) * update stable experiment groups allocation (microsoft#250588) * fix(devcontainer): bump rust feature to fix container build Rust 1.87.0 removed the RLS and rust-analysis components, which led to an error when building the 'rust' devcontainer feature. This commit bumps the feature version to 1.3.3, where those components have been removed from the build script, resolving the issue. Closes: microsoft#250420 Signed-off-by: Oleksandr Zakharov <x.zakharov@proton.me> * handle markdown string correctly, fix bug (microsoft#250653) * Fix for splitting search editor behavior * allow announcement to play when there's no sound for user action required from chat (microsoft#250655) fixes microsoft#250643 * force `instanceLimit` to be at least 1 (microsoft#250657) force instanceLimit to be at least 1 * Fix for pending promise of aisearch * acct for udf setting (microsoft#250663) * make setting experimental (microsoft#250665) * Initial plan for issue * Initial plan for issue * Enhance SendSequence command to support manual input and escape sequences Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * revert addition of `killGracefully` setting (microsoft#250668) revert addition of killGracefully setting microsoft#206607 * Implement workbench.action.terminal.sendSignal command Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Remove redundant writeDataToTerminal command Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Fix race condition in unregistering authentication providers (microsoft#250667) A minimal change for endgame. * commands: fix for startup command in vscode.dev/edu route (microsoft#250680) * commands: fix for startup command in vscode.dev/edu route Closes microsoft/vscode-dev#1290 properly. I didn't realize that, if given a promise, `Promise.resolve` just returns that same promise, so my attempt to hide the `cancel` method didn't work. * update comment * Fix SSE auth in MCP (microsoft#250686) Do retries on 401. * `undo requests` hover padding for consistency (microsoft#250688) padding for hover for consistency * show missingFromGallery warning only when `isEnabled && isRunning` (microsoft#250689) show missingFromGallery warning only when isEnabled && isRunning (microsoft#250433) * fix image hover langauge and some omission issues (microsoft#250692) fix hover isues * Initial plan for issue * Boost main and master branches in terminal suggest completions Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Implement git branch prioritization in compareCompletionsFn - Revert changes to upstream/git.ts per feedback - Add git branch boosting logic to terminalCompletionModel.ts compareCompletionsFn - Boost main and master branches for git commands from terminal-suggest provider - Add comprehensive test suite for git branch priority sorting - Follows same pattern as existing LSP provider boost logic Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * chat - do not activate core agent which is not an extension (microsoft#250717) * Fix casing in setting description * Fix casing in setting description * When revealing/navigation hunks, reveal the line one above so that the deleted-view-zone and its hunk actions are fully visible (microsoft#250721) fixes microsoft#247374 * chat - tweak indicator for setup to more cohorts (microsoft#250724) * update known variables (microsoft#250723) * only show "Configure Tool Sets" when chat and tools are enabled (microsoft#250725) fyi @bpasero * polsih fileLocator.createFilesUpdatedEvent * fix mcp server icon in extensions view (microsoft#250727) * Initial plan for issue * Optimize compareCompletionsFn for better JIT performance Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Fix race condition in terminal quick fix provider registration Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Fix test format errors and improve main/master branch ordering Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Update test files to use SendSequence instead of WriteDataToTerminal Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Fix compilation errors by implementing sendSignal method in missing classes Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Format terminalActions.ts * Remove unused imports * Remove special main/master ordering, use regular completion sorting Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Avoid using accessor after await * Add hack note, improve condition * Move git branch boost below main score check * Tweak tests * fixes microsoft#250734 (microsoft#250735) * Move git branch boost after score comparison to avoid global prioritization Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Revert "Move git branch boost after score comparison to avoid global prioritization" This reverts commit b3275ed. * ployfill `navigator` on NodeJS - but to `undefined` (microsoft#250619) * ployfill `navigator` on NodeJS - but to `undefined` This is used so that we can learn about extensions probing for `navigator` on NodeJS. With latest version this will pass and likely be surprising because navigator historically means browser, not NodeJS * chore: polyfill behind a setting * chore: fix tests * chore: update doc * chore: log err stack in development --------- Co-authored-by: deepak1556 <hop2deep@gmail.com> * fix microsoft#247189 (microsoft#250739) * Show signal command in command palette * hygiene, remove unused * Add signal picker when no args provided to sendSignal command Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Fixes telemetry error * Remove to terminal as it's the category * Add manual signal input option to sendSignal command Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Only show send signal command when no Windows * animate tree indent guides via opacity * Move accessor use to top, await ipc * instructions.md files duplicated in prompts (microsoft#250742) * Localize * updated names in endgame notebook (microsoft#250748) * chore: update @vscode/spdlog@0.15.2 (microsoft#250749) * chore: bump electron@35.5.1 (microsoft#250608) * chore: bump electron@35.5.1 * chore: update build * chore: update distro * Instruction files - comma separated list of glob patterns not working in applyTo property (microsoft#250754) * Instruction files - comma separated list of glob patterns not working in applyTo property * use path, not fsPath * fix test * make sure `InlineAnchorWidget` get disposed (microsoft#250759) fixes microsoft#250758 * Directly query for extension version before declaring it missing (microsoft#250763) * directly query for extension version before declaring it missing * always fire event * show missingFromGallery even when extension is disabled or not running * whitespace * Correct completion kind * Bulk query marketplace check for missingFromMarketplace (microsoft#250775) * bulk query marketplace, add telemetry * send telemetry on non-zero missingcount * more useful telemetry * telemetry for queriedIds and missingIds * no need for an extra loop * force no border on request monaco list row (microsoft#250777) * Fix cell reveal when followCellExecution enabled and notebook tab not active (microsoft#250646) * Initial plan for issue * Fix cell reveal when followCellExecution enabled and notebook tab not active - Add ensureNotebookEditorVisible function to bring notebook tab into view before revealing cells - Modify runCell function to ensure notebook editor is visible when autoReveal is enabled - Update all runCell calls to pass editorService for finding and opening notebook editor - Fixes issue where cells were not revealed when notebook tab was not currently active Co-authored-by: Yoyokrazy <12552271+Yoyokrazy@users.noreply.github.com> * whitespace * rm obvious comment + revealIfOpened * the actual correct solution --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Yoyokrazy <12552271+Yoyokrazy@users.noreply.github.com> Co-authored-by: Michael Lively <milively@microsoft.com> * Chat code block pill token updates (microsoft#250531) * update colors for icon labels to meet accessibility color contrast requirements * - update colors for added and removed labels to pass color contrast requirements - added the used tokens to vscode-known-variables * fixing margin-left * update editor gutter colors for added and deleted resources, removed the previously added gitDecoration tokens from known variables * update editor gutter colors for added and deleted lines in dark_modern and updated the fallback colors for editorGutterDeletedBackground * undoing changes to editorGutterAddedBackground and editorGutterDeletedBackground * add foreground colors for added and deleted lines in chat code blocks in chatColors.ts * add chat foreground colors for added and deleted lines in vscode-known-variables.json * rename chat color variables for added and removed lines in chat code block pill --------- Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com> * hello 1.102.0 (microsoft#250791) * Implements Terminal: Run Recent Command when there are no terminals * Add comments * debt - adopt `findEditors` in more places (microsoft#250712) * fix microsoft#247849 (microsoft#250803) * debt - more powerful layer checker with TS support (microsoft#250752) * SCM - disable variable line height in the input field (microsoft#250802) * Fix extraction of tab title name (microsoft#250621) * Fix extraction of tab title name Fixes microsoft/vscode-internalbacklog#5499 * Engineering - update agent pool --------- Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> * fix microsoft#248686 (microsoft#250810) * replace `wait` util with `timeout` usage * remove `waitRandom` * use `mock` over `mockObject` duplicate * debt - some assorted changes (microsoft#250807) * debt - some assorted fixes * fix ci * remove duplicate dependency * Fix launch.json reference Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> * chore - Use simple suite- and test-names and leave styling up to the reporter (microsoft#250811) * deprecate self-dispose object/pattern (microsoft#250815) migrate cell entry fyi @DonJayamanne re microsoft#248366 * fix microsoft#247820 (microsoft#250816) * Refactoring editor sticky scroll (microsoft#248131) * refactor: enhance documentation for StickyLineCandidateProvider methods microsoft#248082 * Removed unusued statement causing hygiene build to fail microsoft#244845 * polish --------- Co-authored-by: Aiday Marlen Kyzy <aidaymarlenkyzy@gmail.com> Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> * Fix line comment action for makefiles (Fixes microsoft#234464) (microsoft#243283) * Fix line comment action for makefiles (Fixes microsoft#234464) Pass languageId to _analyzeLines to distinguish makefiles from the rest of the languages. Add test to _analyzeLines specifically for makefiles. * Remove hardcoded string. Apply fix at LanguageConfigurationService. Add comment rule to specify fixed column token placement. Change test scope to test line command instead of just testing the _analyzeLines method. * change added field to use bool instead of user-chosen offset * add check to remove comment detection * add check to following space removal * update branch. add config interface for new noindent option. adapt existing logic for new config format. * fix small issue with following space removal * polish --------- Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> * Verify the range is valid before getting the lin max column (microsoft#250450) verify the range is valid before getting the lin max column * Consider line comments when determining indentation (microsoft#250591) * Add setting autoindent on paste (microsoft#250463) * add setting autoindent on paste * setting value to false * remove ignoring of indentation when indenting line comments * adding back code * reveal next file when keep/undoing last hunk (microsoft#250821) * debt - use `esbuild` for CSS minification (microsoft#250820) * avoid const-export-function-expression (microsoft#250826) microsoft#248387 * chore - cleanup decoratior util (microsoft#250827) * no more `asyncTransaction` usage in chat land (microsoft#250831) fixes microsoft#248827 * Fixes microsoft#242059 * Add setting autoIndentOnPasteWithinString (microsoft#250465) * add setting autoindent on paste * setting value to false * autoindentonpastewithinstring * move prompt file actions under vs/workbench/contrib/chat/browser/promptSyntax (microsoft#250836) * Move promptfile actions/pickers under workbench/contrib/chat/browser/promptSyntax * fix * renames * fixes microsoft/vscode-copilot#12412 (microsoft#250843) * move prompt codecs and utils to workbench/contrib/chat/common/promptSyntax (microsoft#250847) * `assertIsDefined` vs `assertDefined` (fix microsoft#248362) (microsoft#250844) * chat - core provided chat submenus in components (microsoft#250851) * Fixes https://github.com/microsoft/vscode-copilot/issues/13637 * Fixes microsoft#230056. (microsoft#250856) Co-authored-by: Dipta Mahardhika <146386738+d-mahard@users.noreply.github.com> * SingleLineEdit -> LineReplacement * chore - remove unused `toolSelectionIsExclusive` fyi @roblourens (microsoft#250860) * Ensure test cases use argument completion kind only * Add more test cases * xterm@5.6.0-beta.110 Fixes microsoft#190629 * Fix hasErrors property for compound task problem matcher events (microsoft#250784) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com> Co-authored-by: meganrogge <merogge@microsoft.com> * Improve debug adapter capabilities checking (microsoft#250779) * some tiny prep work for microsoft#249519 (microsoft#250863) * don't animate visibility, opacity is enough (microsoft#250866) microsoft#250746 * Improve case where active instance already exists * Revert "Merge pull request microsoft#250670 from microsoft/copilot/fix-250669" This reverts commit aa095f8, reversing changes made to 13ff454. * Add picker to sendSequence command Fixes microsoft#250669 * Initial plan for issue * Fix syntax error in quickPickPin.ts getItemIdentifier function Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com> * Add styling for label suffix in attached context attachments * Update label suffix and description opacity to revert to previous styling. * Remove any unexpected properties when persisting pinned item * Make write data and send seqeunce commands use same supprots label Part of microsoft#250669 * Set opacity to 1 for label suffix in chat attached context attachments * Move send signal/sequence into terminalContrib * Inline implementations * Refactor label suffix selector for chat attached context attachments * Move send sequence keybindings into terminalcontrib * Split send signal and sequence into own contribs * mcp: fix resource picker sometimes is empty (microsoft#250892) We didn't trigger a 'change' after the promise resolved, so if we resolve rec.templates and rec.resources synchronously (for a server with no mcp resources) then we could end before publishing everything Refs microsoft#250890 * mcp: fix resource picker sometimes is empty (microsoft#250891) We didn't trigger a 'change' after the promise resolved, so if we resolve rec.templates and rec.resources synchronously (for a server with no mcp resources) then we could end before publishing everything Refs microsoft#250890 * move platform/prompts to vs/workbench/contrib/chat/common/promptSyntax (microsoft#250889) * move platform/prompts to vs/workbench/contrib/chat/common/promptSyntax * promptSync: bring back extension check * mcp: support system message is sampling (microsoft#250900) Ref https://github.com/microsoft/vscode/issues/244162\#issuecomment-2946034316 * testing: preserve path on failed cases (microsoft#250757) Ref Dart-Code/Dart-Code#5534 * cover the constructor as well (microsoft#250675) * mcp: fix authority-less MCP resources cannot be read by VS Code (microsoft#250908) Fixes microsoft#250905 * mcp: adopt finalized completions API, support resolved args for prompts too (microsoft#250909) Refs microsoft#248418 * Add setting to skip word counting/render smoothing (microsoft#250912) * use export function x(...) instead of export const x (microsoft#250927) * debt - improve type and layer checking (microsoft#250926) * mcp: add request trace-level logging (microsoft#250898) * mcp: add request trace-level logging Refs microsoft#250537 * fix * update headers for layers * 🆙 `open@^10.1.2` (microsoft#250980) * debt - restore old layer name (microsoft#250928) * check tool specific enablement when reading tool set (microsoft#250983) fixes microsoft/vscode-copilot#18161 * chore: use node-gyp from build dir for the project (microsoft#250981) * chore: bump node-gyp on windows to 11.2.0 improves reliability of builds on windows includes nodejs/node-gyp#3113 and nodejs/node-gyp#3112 * use preinstalled node-gyp * use bundled node-gyp for subdirs too * chore: revert changes to package-lock.json * chore: rebuild package-lock.json * ci: rebuild cache --------- Co-authored-by: Aman Karmani <aman@tmm1.net> * chore - "Remove File" and "Clear Working Set" action removal. (microsoft#250991) * chore - "Remove File" and "Clear Working Set" action removal. Both are from the time out working set and since a while we have list of modified files so both actions don't make sense anymore * fix compilo * debt - ensure to remove listeners * make sure the API doesn't allow to set an empty selections array (microsoft#251010) re microsoft/vscode-copilot#18075 * api notes/todos (microsoft#251020) * removed commented out code --------- Signed-off-by: Oleksandr Zakharov <x.zakharov@proton.me> Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Luyu Cheng <chengluyu@live.cn> Co-authored-by: Matthew Godin <matthew.godin.dev@gmail.com> Co-authored-by: matthew-godin <150533628+matthew-godin@users.noreply.github.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Joanna Oikawa <parkhurst.joanna@gmail.com> Co-authored-by: Joanna Oikawa <joannaoikawa@Joannas-MacBook-Pro.local> Co-authored-by: Aaron Munger <2019016+amunger@users.noreply.github.com> Co-authored-by: Connor Peet <copeet@microsoft.com> Co-authored-by: Tyler James Leonhardt <2644648+TylerLeonhardt@users.noreply.github.com> Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Bhavya U <bhavyau@microsoft.com> Co-authored-by: Oleksandr Zakharov <x.zakharov@proton.me> Co-authored-by: Osvaldo Ortega <osortega@microsoft.com> Co-authored-by: Osvaldo Ortega <48293249+osortega@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Josh Spicer <23246594+joshspicer@users.noreply.github.com> Co-authored-by: Nick Trogh <1908215+ntrogh@users.noreply.github.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Yoyokrazy <12552271+Yoyokrazy@users.noreply.github.com> Co-authored-by: Michael Lively <milively@microsoft.com> Co-authored-by: Kaitlin Brooks <47866467+kkbrooks@users.noreply.github.com> Co-authored-by: Sublimeful <Qiangwu2000@gmail.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Raffaele Garofalo <raffaeu@gmail.com> Co-authored-by: Aiday Marlen Kyzy <aidaymarlenkyzy@gmail.com> Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Co-authored-by: Enzo Nunes <pedralhoenzo@gmail.com> Co-authored-by: Dipta Mahardhika <146386738+d-mahard@users.noreply.github.com> Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com> Co-authored-by: DrSergei <serzhdruzhok@gmail.com> Co-authored-by: Kaitlin Brooks <kawilkin@microsoft.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Aman Karmani <aman@tmm1.net>

yCodeTech · 2025-07-11T03:18:20Z

And with 1 simple language configuration change, it breaks probably lots of comment extensions that rely on the lineComment being a string. (I was using the String.prototype.includes() to check for a specific comment type which now throws an error when encountering makefile language). Luckily I have a fix for it, but 100s of extensions potentially have been affected.

RedCMD · 2025-07-11T10:13:02Z

VSCode really should provide a getLanguageConfiguration()
we already have setLanguageConfiguration()

vs-code-engineering bot assigned alexr00 Mar 12, 2025

alexr00 assigned aeschli and unassigned alexr00 Mar 12, 2025

Enzo-Nunes force-pushed the fix-234464 branch from 1435cb7 to f944f60 Compare March 13, 2025 17:07

aeschli previously requested changes Mar 14, 2025

View reviewed changes

src/vs/editor/contrib/comment/browser/lineCommentCommand.ts Outdated Show resolved Hide resolved

aeschli assigned hediet and unassigned aeschli Mar 14, 2025

Enzo-Nunes requested a review from aeschli March 15, 2025 02:08

hediet assigned aiday-mar and unassigned hediet Mar 24, 2025

aiday-mar requested review from aiday-mar and removed request for aeschli May 13, 2025 07:34

Enzo-Nunes added 6 commits June 2, 2025 11:24

Fix line comment action for makefiles (Fixes microsoft#234464)

4f8c255

Pass languageId to _analyzeLines to distinguish makefiles from the rest of the languages. Add test to _analyzeLines specifically for makefiles.

Remove hardcoded string. Apply fix at LanguageConfigurationService. A…

c1c40ef

…dd comment rule to specify fixed column token placement. Change test scope to test line command instead of just testing the _analyzeLines method.

change added field to use bool instead of user-chosen offset

a1d3856

add check to remove comment detection

56796ff

add check to following space removal

07c6ed9

update branch. add config interface for new noindent option. adapt ex…

34b3e38

…isting logic for new config format.

Enzo-Nunes force-pushed the fix-234464 branch from 9d3065b to 34b3e38 Compare June 2, 2025 10:58

fix small issue with following space removal

2d9e235

polish

b535571

aiday-mar approved these changes Jun 5, 2025

View reviewed changes

aiday-mar added this to the June 2025 milestone Jun 5, 2025

sandy081 approved these changes Jun 5, 2025

View reviewed changes

aiday-mar enabled auto-merge (squash) June 6, 2025 09:18

aiday-mar merged commit d9145a2 into microsoft:main Jun 6, 2025
7 checks passed

Enzo-Nunes deleted the fix-234464 branch June 6, 2025 09:49

Enzo-Nunes restored the fix-234464 branch June 6, 2025 09:53

yCodeTech mentioned this pull request Jul 11, 2025

[BUG]: single-line comment fails in VS Code June release yCodeTech/auto-comment-blocks#10

Closed

vs-code-engineering bot locked and limited conversation to collaborators Jul 21, 2025

Fix line comment action for makefiles (Fixes #234464) #243283

Fix line comment action for makefiles (Fixes #234464) #243283

Uh oh!

Conversation

Enzo-Nunes commented Mar 12, 2025

Uh oh!

Enzo-Nunes commented Mar 12, 2025

Uh oh!

Uh oh!

Namiland commented Mar 15, 2025

Uh oh!

Enzo-Nunes commented Mar 15, 2025

Uh oh!

Enzo-Nunes commented Mar 24, 2025

Uh oh!

hediet commented Mar 24, 2025

Uh oh!

Enzo-Nunes commented Mar 24, 2025

Uh oh!

hediet commented Mar 24, 2025

Uh oh!

Enzo-Nunes commented Mar 24, 2025

Uh oh!

aiday-mar commented Mar 24, 2025

Uh oh!

Enzo-Nunes commented Mar 24, 2025

Uh oh!

Enzo-Nunes commented Mar 24, 2025

Uh oh!

RedCMD commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Enzo-Nunes commented Mar 24, 2025

Uh oh!

Enzo-Nunes commented Mar 31, 2025

Uh oh!

aiday-mar commented Apr 16, 2025

Uh oh!

Enzo-Nunes commented Apr 16, 2025

Uh oh!

aiday-mar commented May 7, 2025

Uh oh!

Enzo-Nunes commented May 8, 2025

Uh oh!

aiday-mar commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Enzo-Nunes commented Jun 2, 2025

Uh oh!

Enzo-Nunes commented Jun 2, 2025

Uh oh!

aiday-mar commented Jun 5, 2025

Uh oh!

aiday-mar commented Jun 5, 2025

Uh oh!

Enzo-Nunes commented Jun 5, 2025

Uh oh!

sandy081 commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aiday-mar commented Jun 5, 2025

Uh oh!

Uh oh!

yCodeTech commented Jul 11, 2025

Uh oh!

RedCMD commented Jul 11, 2025

Uh oh!

Uh oh!

RedCMD commented Mar 24, 2025 •

edited

Loading

aiday-mar commented Jun 2, 2025 •

edited

Loading

sandy081 commented Jun 5, 2025 •

edited

Loading