Finalize Shell API #243274
Merged
Finalize Shell API #243274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
previously approved these changes
Mar 11, 2025
Tyriar
requested changes
Mar 12, 2025
mjbvz
requested changes
Mar 13, 2025
Tyriar
requested changes
Mar 13, 2025
Tyriar
requested changes
Mar 13, 2025
Tyriar
previously approved these changes
Mar 14, 2025
mjbvz
previously approved these changes
Mar 14, 2025
Tyriar
approved these changes
Mar 15, 2025
mjbvz
approved these changes
Mar 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230165
From API sync, we decided to move on with few changes:
shellType->shellKind->shellsinceshellwas already being used elsewhere.shellto string, so now we have much less maintenance duty (no need to keep long list), and this is much easier to use.I wanted to make sure we updated all of the code related to terminal suggest that uses this api.
TODO: Update Python environment extension when this shell API gets finalized and merged.
End goal of this PR is to remove
src/vscode-dts/vscode.proposed.terminalShellType.d.tsand request for finalization hereby, againstvscode.d.t.s