adds images in history, create file for pasted images in chat #241664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Feb 24, 2025
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
TylerLeonhardt
previously approved these changes
Feb 24, 2025
roblourens
reviewed
Feb 24, 2025
roblourens
reviewed
Feb 24, 2025
roblourens
reviewed
Feb 24, 2025
roblourens
reviewed
Feb 24, 2025
| // A funtion that filters out specifically the `value` property of the attachment. | ||
| private getFilteredEntry(query: string, inputState: IChatInputState): IChatHistoryEntry { | ||
| const attachmentsWithoutImageValues = inputState.chatContextAttachments?.map(attachment => { | ||
| if (attachment.isImage && attachment.references?.length && attachment.value) { |
There was a problem hiding this comment.
Is there some case where an image attachment doesn't have references, and then the image data will still be saved in history?
There was a problem hiding this comment.
there shouldn't be case where images don't have references (besides if it comes from web and is an image, then it is okay because the value will be a URL)
roblourens
approved these changes
Feb 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #240026