Skip to content

Fix #238815 by using a function that calls downloadAndInstall for local downloads #241400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix #238815 by using a function that calls downloadAndInstall for local downloads #241400

merged 1 commit into from
Feb 20, 2025

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Feb 20, 2025 •
edited
Loading

Ref microsoft/vscode-remote-release#9090
Follow up to #238815

We need to call a function that will eventually call RemoteExtensionManagementService.downloadAndInstall, since that is the one able to download extensions on the local side.

In the window log on your client

2025-02-20 14:32:01.820 [info] [Window] Downloading the 'joshspicer.touchbarcommandshortcuts' extension locally and install
2025-02-20 14:32:02.348 [info] [Window] Downloaded extension: joshspicer.touchbarcommandshortcuts /Users/jospicer/.vscode-oss-dev/CachedExtensionVSIXs/joshspicer.touchbarcommandshortcuts-0.0.2
2025-02-20 14:32:02.498 [info] [Window] Successfully installed 'joshspicer.touchbarcommandshortcuts' extension

@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 20, 2025
@joshspicer joshspicer merged commit 9654eb2 into main Feb 20, 2025
8 checks passed
@joshspicer joshspicer deleted the joshspicer/whenExtensionsReady-logging branch February 20, 2025 22:33
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@joshspicer joshspicer

Labels
None yet
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@joshspicer @rzhao271