Skip to content

assign a cell Id to the internal metadata on the cell's text model #240733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

assign a cell Id to the internal metadata on the cell's text model #240733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d43726
add cellId to internal metadata
Feb 13, 2025
2bce472
pipe internal metadata to worker
Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/vs/workbench/contrib/notebook/common/model/notebookCellTextModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ export class NotebookCellTextModel extends Disposable implements ICell {
this._outputs = outputs.map(op => new NotebookCellOutputTextModel(op));
this._metadata = metadata ?? {};
this._internalMetadata = internalMetadata ?? {};
this._internalMetadata.cellId = this._internalMetadata.cellId ??
this._metadata.id as string ??
uri.fragment;
}

enableAutoLanguageDetection() {
Expand Down
1 change: 1 addition & 0 deletions src/vs/workbench/contrib/notebook/common/notebookCommon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export interface NotebookCellMetadata {
}

export interface NotebookCellInternalMetadata {
cellId?: string;
executionId?: string;
executionOrder?: number;
lastRunSuccess?: boolean;
Expand Down
3 changes: 2 additions & 1 deletion src/vs/workbench/contrib/notebook/common/services/notebookSimpleWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ export class NotebookEditorSimpleWorker implements IRequestHandler, IDisposable
dto.language,
dto.cellKind,
dto.outputs,
dto.metadata
dto.metadata,
dto.internalMetadata
)), metadata, transientDocumentMetadata);
}

Expand Down
Loading