Skip to content

wco - hardcode devtools location on Linux #227084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2024
Merged

wco - hardcode devtools location on Linux #227084

merged 3 commits into from
Aug 29, 2024

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Aug 29, 2024

At least for now until Electron has adopted a fix.

@bpasero bpasero self-assigned this Aug 29, 2024
@bpasero bpasero marked this pull request as ready for review August 29, 2024 14:54
@bpasero bpasero added this to the August 2024 milestone Aug 29, 2024
@bpasero bpasero enabled auto-merge (squash) August 29, 2024 14:54
@bpasero bpasero merged commit dfb96d1 into main Aug 29, 2024
6 checks passed
@bpasero bpasero deleted the ben/sleepy-chickadee branch August 29, 2024 15:08
deepak1556 added a commit that referenced this pull request Sep 18, 2024
deepak1556 added a commit that referenced this pull request Sep 19, 2024
deepak1556 added a commit that referenced this pull request Sep 20, 2024
deepak1556 added a commit that referenced this pull request Sep 23, 2024
deepak1556 added a commit that referenced this pull request Sep 25, 2024
deepak1556 added a commit that referenced this pull request Sep 26, 2024
deepak1556 added a commit that referenced this pull request Oct 2, 2024
deepak1556 added a commit that referenced this pull request Oct 3, 2024
deepak1556 added a commit that referenced this pull request Oct 4, 2024
* chore: update electron@31.0.1

* chore: bump electron@31.1.0

* chore: update sysroot download url

* chore: bump electron@31.3.0

* chore: update rpm deps for arm64

* chore: bump electron@31.4.0

* chore: bump electron@32.0.0

* fix: compile stage

* fix: install on windows

* fix: override node-addon-api to support c++20 with gcc-11

Brings in nodejs/node-addon-api@fed1353
to support compilation with gcc>=11

* ci: use gnu++2a for gcc <=9

* ci: fix sdl pipeline

* ci: web stage

* ci: fix alpine stage

* ci: fix legacy server stage

* fix: node-addon-api resolution for remote

* ci: fix legacy arm stage

* chore: sync npm dependencies

* chore: bump electron@32.0.1

* ci: fix monaco editor checks

* ci: fix legacy server stage

* ci: possible concurrent execution

* ci: use foreground scripts on windows

* chore: bump electron@32.0.2

* fix: compilation

Refs electron/electron@204011c

* Revert "wco - hardcode devtools location on Linux (#227084)"

This reverts commit dfb96d1.

* chore: bump electron@32.1.2

* ci: remove workaround for missing c++20 flags

* ci: use gnu++2a for gcc <=9

* chore: bump distro

* ci: use gnu++17 for legacy arm servers

* fixup! override node-addon-api to support c++20 with gcc-11

Scope to only the affected package versions

* chore: bump @vscode/policy-watcher

* chore: bump @vscode/sqlite3

* chore: bump node.js v20.17.0

* chore: bump distro

* chore: update @vscode/windows-ca-certs

* chore: update builds for electron@32.1.2

* chore: bump distro

* chore: bump dependencies

* ci: fix arm legacy servers
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants