Fixes #204257. Refactors AccessibilitySignalService and renames LineFeatures to TextProperties. #210679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204257, supersedes #205320
This PR implements support for different (not configurable yet) delays for
... each per modality (sound/announcement) and per signal (warning/error/breakpoints).
Also, when a positional signal is triggered, the corresponding line signal will not be triggered.
If the user types, the debounce time increases by 1 second.
If text properties appear while the user does not change the cursor, they are announced with the same delay as if they were triggered by explicit cursor movement.