Skip to content

Add code cell symbols to nb outline + debt fixes #208323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2024
Merged

Add code cell symbols to nb outline + debt fixes #208323

merged 4 commits into from
Mar 21, 2024

Conversation

Yoyokrazy
Copy link
Collaborator

re #206308

Includes:

  • code cell symbols as children of code cells in the notebook outline
  • filtering logic moved out of the outlineProvider into getChildren of notebookCellOutline
  • stickyScroll adjusted for new level 8 outlineEntry (symbol entries)

@Yoyokrazy Yoyokrazy requested a review from rebornix March 21, 2024 18:05
@Yoyokrazy Yoyokrazy self-assigned this Mar 21, 2024
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 21, 2024
@Yoyokrazy
Copy link
Collaborator Author

Yoyokrazy commented Mar 21, 2024 •
edited
Loading

todo:

  • need to fix some notebook symbol tests

@Yoyokrazy
Copy link
Collaborator Author

updates:

  • settings defined in notebookCommon for outline showCodeCells, showCodeCellSymbols, and showMarkdownHeadersOnly.
  • settings defined in notebookCommon for breadcrumbs showCodeCells
  • filter logic moved to notebookOutline getChildren fn
  • symbols from code cells are now OutlineEntry level 8+ (keeps them as children of code cells in outlinePane)
  • outlineEntryFactory now takes the OutlineTarget (helps control whether a code cell entry is pushed. needed in outlinePane, not in quickPick)

@Yoyokrazy Yoyokrazy merged commit 9f1605b into main Mar 21, 2024
@Yoyokrazy Yoyokrazy deleted the nuclear-loon branch March 21, 2024 22:04
@Yoyokrazy Yoyokrazy mentioned this pull request Mar 21, 2024
Closed
10 tasks
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@Yoyokrazy Yoyokrazy

Labels
None yet
Projects
None yet
Milestone
March 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Yoyokrazy @rebornix @vscodenpa