Skip to content

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Feb 17, 2017

Fixes #20832

Adds a prototype code lens that shows the number of implementations for interfaces and abstract classes. This shares a lot of code with the references code lens provider, so I extracted most of the common stuff into a base class.

Currently, implementation counts are only shown on abstract classes, abstract methods, and interfaces

screen shot 2017-02-16 at 11 08 05 pm

Todo

  • Show on interface members.
  • Add setting to toggle this on and off
  • Think about the expected behavior. Should this also show up for inheritance / overriden methods
  • Remove more duplicate code

@mention-bot
Copy link

@mjbvz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken and @dbaeumer to be potential reviewers.

@mjbvz mjbvz force-pushed the prototype-implementations-code-lens branch from db4d774 to 5910324 Compare February 17, 2017 19:49
@mjbvz mjbvz added this to the March 2017 milestone Feb 17, 2017
Adds a prototype code lens that shows the number of implementations for interfaces and abstract classes. This shares a lot of code with the references code lens provider, so I extracted most of the common stuff into a base class.
@mjbvz mjbvz force-pushed the prototype-implementations-code-lens branch from 96dfc89 to 7d5971a Compare March 1, 2017 01:12
@mjbvz mjbvz merged commit 223ea4b into microsoft:master Mar 1, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementations Code Lens For TypeScript
3 participants