Skip to content

Conversation

Yoyokrazy
Copy link
Collaborator

@Yoyokrazy Yoyokrazy commented Mar 12, 2024

re #206308

Contributes a toolbar to the outline entry items in the notebook outline pane. Toolbar continues some or none of the following actions:

  • Run Cells in Section
  • Run Cell
  • Fold Section

Future thoughts:

  • Fold Section wording
    • This technically performs a "toggle folding range" action, but I'm hesitant to use the word toggle as it only controls the notebook editor view state, not the outline view state. Maybe an item for the future.
    • Could be more fitting to have two separate actions, one for Fold Section and one for Expand Section. Would be easy to have the actions only show depending on the cell's folding state via a context key.
  • Add a minimum time to the spinner in the outline view, similar to the cell execution status item in the cell status bar (think this was 500ms?)

@Yoyokrazy Yoyokrazy requested a review from rebornix March 12, 2024 19:03
@Yoyokrazy Yoyokrazy self-assigned this Mar 12, 2024
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 12, 2024
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@Yoyokrazy Yoyokrazy enabled auto-merge (squash) March 14, 2024 17:29
@Yoyokrazy Yoyokrazy merged commit 88d1e2c into main Mar 14, 2024
@Yoyokrazy Yoyokrazy deleted the milively/outline-toolbar branch March 14, 2024 17:29
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run notebook section from outline Jupyter notebook, run a section Add "play" button to Outline for jupyter notebooks
3 participants