Skip to content

Support Tabs vs Spaces in notebook editors #204783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2024
Merged

Support Tabs vs Spaces in notebook editors #204783

merged 3 commits into from
Feb 12, 2024

Conversation

Yoyokrazy
Copy link
Collaborator

@Yoyokrazy Yoyokrazy commented Feb 8, 2024 •
edited
Loading

Fixes: #108675

Currently you can control the indentation modes for notebook editors via the setting:
"notebook.editorOptionsCustomizations": {}

For example:

"notebook.editorOptionsCustomizations": {
	"editor.detectIndentation": false,
	"editor.indentSize": "tabSize",
	"editor.tabSize": 16,
	"editor.insertSpaces": true,
},

@Yoyokrazy Yoyokrazy requested a review from rebornix February 8, 2024 22:50
@Yoyokrazy Yoyokrazy self-assigned this Feb 8, 2024
@Yoyokrazy
Copy link
Collaborator Author

Yoyokrazy commented Feb 8, 2024 •
edited
Loading

Todo: hook up command for statusbar entry to change indentation types (coming in a separate PR)

@Yoyokrazy Yoyokrazy marked this pull request as ready for review February 8, 2024 23:01
@vscodenpa vscodenpa added this to the February 2024 milestone Feb 8, 2024
rebornix
rebornix approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's make sure we have issues tracking https://github.com/microsoft/vscode/pull/204783/files#diff-4677a47fd6ba528332f9c7620a387a37bc7092af04591fdcb1a16701f8fe5951R97 and in this PR we already have two places parsing the indent* settings ourselves.

@Yoyokrazy Yoyokrazy merged commit c4bea7b into main Feb 12, 2024
@Yoyokrazy Yoyokrazy deleted the milively/tabs-vs-spaces branch February 12, 2024 17:32
@Yoyokrazy Yoyokrazy mentioned this pull request Feb 12, 2024
Open
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@Yoyokrazy Yoyokrazy

Labels
None yet
Projects
None yet
Milestone
February 2024
Development

Successfully merging this pull request may close these issues.

Cannot pick tabs vs spaces in notebook
3 participants
@Yoyokrazy @rebornix @vscodenpa