Skip to content

fix: Close #191877, Correct the root path of the saved file #191878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Close #191877, Correct the root path of the saved file #191878

wants to merge 1 commit into from

Conversation

yiliang114
Copy link
Contributor

@yiliang114 yiliang114 commented Aug 31, 2023 •
edited
Loading

The directory that can be selected at the last level should theoretically be the root directory of the current workspace, but not / (from resource.dirname)

@deepak1556 deepak1556 assigned bpasero and unassigned deepak1556 Aug 31, 2023
@bpasero bpasero assigned alexr00 and unassigned bpasero Aug 31, 2023
alexr00
alexr00 reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, but this isn't the best fix for #191877. The simple file dialog is used in other places and does allow saving outside the workspace there.

@alexr00 alexr00 closed this Aug 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 left review comments

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yiliang114 @alexr00 @bpasero @deepak1556 @vscodenpa