Skip to content

fix: select theme according to current color theme in dev mode #190035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

harbin1053020115
Copy link
Contributor

To #190034

@aeschli
Copy link
Contributor

aeschli commented Aug 16, 2023

Can you explain what's the intention?

@harbin1053020115
Copy link
Contributor Author

Can you explain what's the intention?

When developping a color theme extension, which I defined more than one color themes, vscode will always initialize with the first color themes provided by my color theme extension after reload browser(vscode in web), see the code blew:
image
I expected that vscode will initialize the color theme which is used before.

@aeschli
Copy link
Contributor

aeschli commented Dec 18, 2023

I expected that vscode will initialize the color theme which is used before.

With the suggested code change it will still pick a theme from the extension under dev. But only if it provides a theme of the same type (dark, light....)
I don't think that makes things easier to understand...

@aeschli
Copy link
Contributor

aeschli commented Dec 18, 2023

Ah, but it defaults to the first.
Sure, why not.

@aeschli aeschli enabled auto-merge (squash) December 18, 2023 14:00
@aeschli aeschli added this to the December / January 2024 milestone Dec 18, 2023
@aeschli aeschli merged commit 74df98f into microsoft:main Dec 18, 2023
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants