Add tunnel activation event #189936
Merged
Add tunnel activation event #189936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamah
previously approved these changes
Aug 8, 2023
|
Looks like there's a service dependency cycle that I need to resolve. |
auto-merge was automatically disabled
August 8, 2023 19:27
Pull request was converted to draft
connor4312
approved these changes
Aug 8, 2023
|
The activation event looks okay, but in this PR the "Ports" view and "Forward a Port" commands aren't available unless there's an activated extension that has registered a tunnel factory. I think these would need to be shown if an extension has |
|
@connor4312 thanks for noticing this! For now, I'll make a change to show the Ports view if there's an "onTunnel" extension installed. I'm not sure if we have a precedent of doing this, but it will be fine until I can bring it to the API sync. I'll make the change in a separate PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188730