Skip to content

fix: Close #189556, gulp task do not display task name #189557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 15, 2023
Merged

fix: Close #189556, gulp task do not display task name #189557

merged 8 commits into from
Aug 15, 2023

Conversation

yiliang114
Copy link
Contributor

@yiliang114 yiliang114 commented Aug 3, 2023 •
edited by meganrogge
Loading

fixes #189556

After add Task Name

image

meganrogge
meganrogge previously approved these changes Aug 3, 2023
View reviewed changes
@meganrogge meganrogge requested a review from alexr00 August 3, 2023 16:50
@meganrogge
Copy link
Contributor

meganrogge commented Aug 3, 2023 •
edited
Loading

The git repo is not clean after compiling the /build/ folder. Did you forget to commit .js output for .ts files?

thanks for working on this. the above error is present

alexr00
alexr00 reviewed Aug 7, 2023
View reviewed changes
alexr00
alexr00 reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type of the changed functions seems fishy to me.

alexr00
alexr00 previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though @meganrogge I don't think this has much to do with VS Code tasks. As far as I can tell the printing of the name is here:
https://github.com/yiliang114/vscode/blob/818ae5029a3792e31804be7ad83e30c42f063eb0/build/lib/task.ts#L38-L39

@meganrogge
Copy link
Contributor

it's still failing. @alexr00 looks like @alexdima added this code originally, so maybe he should have a look, though it's been awhile

@yiliang114
Copy link
Contributor Author

it's still failing. @alexr00 looks like @alexdima added this code originally, so maybe he should have a look, though it's been awhile

Is it a compile error in the build directory?

@meganrogge
Copy link
Contributor 

The git repo is not clean after compiling the /build/ folder. Did you forget to commit .js output for .ts files?

@yiliang114
Copy link
Contributor Author

yiliang114 commented Aug 8, 2023 •
edited
Loading 

The git repo is not clean after compiling the /build/ folder. Did you forget to commit .js output for .ts files?

Sorry, I have modified this compilation.ts file and its compiled products compilation.js , which have already been submitted. What do you mean by forgetting to submit? @meganrogge

image

@meganrogge
Copy link
Contributor

maybe try removing this file from the changes?

build/lib/compilation.js

@yiliang114
Copy link
Contributor Author

maybe try removing this file from the changes?

build/lib/compilation.js

Okay, I 've already done that

@yiliang114 yiliang114 requested a review from alexr00 August 15, 2023 16:21
@meganrogge meganrogge enabled auto-merge August 15, 2023 17:17
@meganrogge
Copy link
Contributor

Thanks for your work @yiliang114 !

@meganrogge meganrogge merged commit 31a6f1d into microsoft:main Aug 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connor4312 connor4312 connor4312 approved these changes

@meganrogge meganrogge meganrogge approved these changes

@alexr00 alexr00 Awaiting requested review from alexr00

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gulp task do not display task name
4 participants
@yiliang114 @meganrogge @connor4312 @alexr00