Skip to content

chore: update to Electron 25 #188268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 7, 2023
Merged

chore: update to Electron 25 #188268

merged 16 commits into from
Aug 7, 2023

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Jul 19, 2023 •
edited
Loading

Fixes #184021
Fixes #189384
Fixes #188769
Fixes #188757

@deepak1556 deepak1556 mentioned this pull request Jul 19, 2023
Closed
@deepak1556 deepak1556 added this to the On Deck milestone Jul 19, 2023
@deepak1556 deepak1556 self-assigned this Jul 19, 2023
@deepak1556 deepak1556 force-pushed the electron-25.x.y branch 3 times, most recently from 392dd63 to 5717d25 Compare July 19, 2023 14:21
@skapin
Copy link

skapin commented Jul 20, 2023

do you have an ETA for this ?

@henkery henkery mentioned this pull request Jul 20, 2023
Closed
@deepak1556 deepak1556 mentioned this pull request Jul 20, 2023
Merged
@deepak1556 deepak1556 force-pushed the electron-25.x.y branch 11 times, most recently from 4050547 to 20ad537 Compare July 27, 2023 10:56
@deepak1556 deepak1556 force-pushed the electron-25.x.y branch 2 times, most recently from f8f6faa to 28a8c1f Compare July 31, 2023 14:01
@beto811 beto811 mentioned this pull request Jul 31, 2023
Closed
@deepak1556 deepak1556 force-pushed the electron-25.x.y branch 6 times, most recently from cb1169e to 93d3731 Compare August 7, 2023 03:29
@deepak1556 deepak1556 removed this from the On Deck milestone Aug 7, 2023
@deepak1556 deepak1556 requested a review from bpasero August 7, 2023 09:48
@deepak1556 deepak1556 marked this pull request as ready for review August 7, 2023 09:48
bpasero
bpasero previously approved these changes Aug 7, 2023
View reviewed changes
@deepak1556 deepak1556 requested a review from bpasero August 7, 2023 12:16
@deepak1556 deepak1556 merged commit ea490e5 into main Aug 7, 2023
@deepak1556 deepak1556 deleted the electron-25.x.y branch August 7, 2023 12:46
@tengyifei
Copy link

I'm getting a segfault on the latest insider release but it failed to write a crash dump:

[0807/191647.329175:ERROR:directory_reader_posix.cc(42)] opendir /home/yifeit/.config/Code - Insiders/Crashpad/attachments/ee4393f9-542a-4e1a-8a39-1ada6f0fea30: No such file or directory (2)
[1]    1330180 segmentation fault  WAYLAND_DEBUG=1 /usr/share/code-insiders/code-insiders

What's the best way to get a crash dump so I could file an issue?

@deepak1556
Copy link
Collaborator Author

You can follow the steps here https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-a-crash-report to get the crash logs, thanks!

@tengyifei
Copy link

@deepak1556 I made #189956. Thank you!

@andreamah andreamah mentioned this pull request Aug 8, 2023
Open
@vince-fugnitto vince-fugnitto mentioned this pull request Aug 23, 2023
Closed
@tats-u tats-u mentioned this pull request Sep 18, 2023
Open
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
August 2023
4 participants
@deepak1556 @skapin @tengyifei @bpasero