Skip to content

Conversation

hediet
Copy link
Member

@hediet hediet commented Jul 11, 2023

Fixes #185028

@hediet hediet enabled auto-merge (squash) July 11, 2023 16:40
@vscodenpa vscodenpa added this to the July 2023 milestone Jul 11, 2023
@meganrogge
Copy link
Contributor

meganrogge commented Jul 11, 2023

When I test, the editor is used because the context key result is false here.

I'm just using a side by side diff editor - perhaps I need to test in a v2 diff editor?
Screenshot 2023-07-11 at 10 24 57 AM

@meganrogge
Copy link
Contributor

You'll also want to add an accessibility.verbosity setting similar to what is done for the other features so that users discover this menu

@meganrogge
Copy link
Contributor

using diff editor v2 and still not seeing the right help menu - are you?

Screenshot 2023-07-11 at 1 12 10 PM

@hediet
Copy link
Member Author

hediet commented Jul 11, 2023

using diff editor v2 and still not seeing the right help menu - are you?

You have to reload the window after changing the setting unfortunately.

@meganrogge
Copy link
Contributor

Perhaps we should also mention the audio cues that can be configured for this?

Screenshot 2023-07-11 at 1 46 58 PM

@hediet
Copy link
Member Author

hediet commented Jul 11, 2023

Perhaps we should also mention the audio cues that can be configured for this?

Good point! Though they should be enabled by default for screen reader users.

@meganrogge
Copy link
Contributor

Yeah, but it's possible they will find some annoying, so we should let them know they can be disabled

meganrogge
meganrogge previously approved these changes Jul 11, 2023
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍🏼

@hediet hediet merged commit 84d97b6 into main Jul 12, 2023
@hediet hediet deleted the hediet/b/thundering-heron branch July 12, 2023 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add accessible help menu for diff editor
4 participants