turning highlighted Markdown text to link to pasted URL #185924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
reviewed
Jun 22, 2023
extensions/markdown-language-features/src/languageFeatures/copyFiles/copyPasteLinks.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/copyPasteLinks.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
mjbvz
requested changes
Jun 26, 2023
extensions/markdown-language-features/src/languageFeatures/copyFiles/copyPasteLinks.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/dropOrPasteInto/browser/postEditWidget.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/copyPasteLinks.ts
Outdated
Show resolved
Hide resolved
mjbvz
requested changes
Jun 26, 2023
| const snippetEdits = coalesce(activeEditor.selections.map((selection, i): vscode.SnippetTextEdit | undefined => { | ||
| const selectionText = activeEditor.document.getText(selection); | ||
| const snippet = createUriListSnippet(activeEditor.document, selectedFiles, { | ||
| const snippet = createUriListSnippet(activeEditor.document, selectedFiles, title, placeholderValue, { |
There was a problem hiding this comment.
What's the difference between these new arguments and the existing placeholderText / placeholderStartIndex values passed in below?
There was a problem hiding this comment.
I did not want to change to existing functionality of insertResource.ts, so I wanted to keep placeholderText and placeholderString as they are. I made an edit in shared.ts that will hopefully make more sense.
extensions/markdown-language-features/src/languageFeatures/copyFiles/copyPaste.ts
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/copyPasteLinks.ts
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
Outdated
Show resolved
Hide resolved
mjbvz
approved these changes
Jun 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing ability for pasting over highlighted Markdown text to turn the text into a link to the pasted URL
Fixes #179628