Skip to content

Allow to mark files as readonly #181708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 10, 2023
Merged

Allow to mark files as readonly #181708

merged 23 commits into from
May 10, 2023
+673 −143

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented May 6, 2023 •
edited
Loading

@bpasero bpasero mentioned this pull request May 6, 2023
Closed
@bpasero bpasero added this to the May 2023 milestone May 6, 2023
@Fluffik3666
Copy link

good job

@bpasero bpasero marked this pull request as ready for review May 8, 2023 14:00
TylerLeonhardt
TylerLeonhardt previously approved these changes May 8, 2023
View reviewed changes
TylerLeonhardt
TylerLeonhardt previously approved these changes May 8, 2023
View reviewed changes
@bpasero bpasero mentioned this pull request May 9, 2023
Closed
@bpasero bpasero linked an issue May 9, 2023 that may be closed by this pull request
Add read-only mode #4873
Closed
@jackpunt jackpunt mentioned this pull request May 9, 2023
Merged
jackpunt and others added 4 commits May 10, 2023 06:05
@jackpunt @jpeckj @bpasero
precedence for isReadonly() for #181708 (#181955)
05632b6 
* precedence in isReadonly

* still use `stat.readonly`

---------

Co-authored-by: jackpunt <jpeckj@gmail.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
@bpasero
Settings: allow include patterns (fix #181789)
0a877df
@bpasero
readonly - conditionally enable actions
c62f6d9
@bpasero
readonly - enable for vscode workspace
d64c580
joaomoreno
joaomoreno previously approved these changes May 10, 2023
View reviewed changes
@bpasero bpasero enabled auto-merge May 10, 2023 12:45
@bpasero bpasero merged commit 45b57b3 into main May 10, 2023
@bpasero bpasero deleted the ben/readonly-files branch May 10, 2023 13:07
@Veykril Veykril mentioned this pull request May 10, 2023
Open
@bpasero bpasero linked an issue May 11, 2023 that may be closed by this pull request
Set editor readonly for files that are readonly on disk #17670
Closed
@newbie01github
Copy link

I am using Version 1.78.2 and can't find this settings. Is this dependent on the file that is being opened to be in READ ONLY too? I just want to be able to open file for viewing as READ ONLY so I don't accidentally edit the file :( especially if I am just comparing it with another file.

@bpasero
Copy link
Member Author

bpasero commented May 22, 2023

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt left review comments

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

Set editor readonly for files that are readonly on disk Add read-only mode
6 participants
@bpasero @Fluffik3666 @newbie01github @joaomoreno @TylerLeonhardt @jackpunt