Skip to content

fix: Close#171402, fix label name with undefined #171404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Close#171402, fix label name with undefined #171404

wants to merge 1 commit into from

Conversation

yiliang114
Copy link
Contributor

@yiliang114 yiliang114 commented Jan 16, 2023 •
edited
Loading

1673858705195-31816213-d9c7-473b-9601-d71b06bc4b7e

Close #171402

@deepak1556 deepak1556 assigned bpasero and unassigned deepak1556 Jan 16, 2023
@bpasero bpasero requested a review from aeschli January 16, 2023 10:38
@yiliang114
Copy link
Contributor Author

Before processing：

After processing:
image

@bpasero
Copy link
Member

bpasero commented Jan 16, 2023

Thanks but I would prefer a fix where we handle the extension point, will open a new PR: #171412

@bpasero bpasero closed this Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschli aeschli Awaiting requested review from aeschli

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label name with undefined when the workspace is not named
4 participants
@yiliang114 @bpasero @deepak1556 @vscodenpa