Try mangling _private service props
#165117
Conversation
Results in a slight reduction in code size. Needs more testing
|
Change looks good, unsure about the CI failure tho |
|
Could this be failing because folks use |
|
@jrieken Where were seeing the failures? I created a private build (13c08c6). It failed for unrelated reasons. I will kick off another test build though I also sanity checked the bits that succeeded and everything seems to run ok |
|
Sorry, saw the wrong/bogous build failure. Anyways, I do believe there is an inherent risk with this or I am missing something. We have many injected services using As a related FYI: I have updated #165259 to only check for |
|
@jrieken My understanding of property mangling is that it operates on the entire bundle (not per file). If a |
|
Closing in favor of #166126 |
This enables property mangling for properties with names such as
_someService. This is designed to only touch properties that we are confident can be mangled safely (in this case, any private services)This results in a very small (0.75%) reduction in the size of workbench.js. For the future:
If we mangle every
this.someServiceproperty, we could reduce the bundle size by 4%If we mangle every
this._privatePropproperties, we could reduce the bundle size by 6%. We could likely save more by adopting_names for private props in more placesIf we mangle every property, we'd reduce by bundle size by 40% (this is only theoretically, as doing this completely breaks the code)