Skip to content

try hybrid model for editor features menu #164493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

try hybrid model for editor features menu #164493

merged 1 commit into from
Oct 24, 2022

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Oct 24, 2022 •
edited
Loading

fixes #158458

cc @jrieken @daviddossett
This outcome:

  • is a hybrid model
  • puts the most frequently used command in the same old place
  • allows us to reduce the length of the main view menu
  • reduces our distinction between editor and workbench actions which are not important here

image

@sbatten sbatten enabled auto-merge (squash) October 24, 2022 19:41
@sbatten sbatten self-assigned this Oct 24, 2022
@vscodenpa vscodenpa added this to the October 2022 milestone Oct 24, 2022
@sbatten sbatten merged commit 867f456 into main Oct 24, 2022
@sbatten sbatten deleted the sbatten/drab-mink branch October 24, 2022 19:56
formigoni pushed a commit to formigoni/vscode that referenced this pull request Oct 27, 2022
@sbatten @formigoni
try hybrid model for editor features menu (microsoft#164493)
5be6e53 
fixes microsoft#158458
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@mjbvz mjbvz mjbvz approved these changes

Assignees

@sbatten sbatten

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.

View menu consistency and length
4 participants
@sbatten @Tyriar @mjbvz @vscodenpa