Skip to content

add accessibility setting tag #163358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2022
Merged

add accessibility setting tag #163358

merged 2 commits into from
Oct 12, 2022

Conversation

meganrogge
Copy link
Contributor

Also adds a command to go to the accessibility settings
fix #162459

@meganrogge meganrogge requested a review from isidorn October 11, 2022 20:57
@meganrogge meganrogge self-assigned this Oct 11, 2022
@meganrogge meganrogge added this to the October 2022 milestone Oct 11, 2022
@isidorn
Copy link
Collaborator

isidorn commented Oct 12, 2022

Looks good -> approved.
I will test it out in insiders tomorrow and will provide more feedback then.
Thanks for working on this 👏

isidorn
isidorn previously approved these changes Oct 12, 2022
View reviewed changes
@isidorn
Copy link
Collaborator

isidorn commented Oct 12, 2022

We also have the workbench.reduceMotion setting. I think it also deserves the accessibility tag.

@meganrogge meganrogge merged commit 6f7820c into main Oct 12, 2022
@meganrogge meganrogge deleted the merogge/access-tag branch October 12, 2022 22:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@isidorn isidorn isidorn left review comments

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.

@tag for accessibility settings
3 participants
@meganrogge @isidorn @rzhao271