Workaround Safari clipboard.writeText behavior #139657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
commented
Dec 22, 2021
| if (isSafari) { | ||
| this.logService.error(error); | ||
|
|
||
| return ''; // Safari does not seem to provide anyway to enable cipboard access (https://github.com/microsoft/vscode-internalbacklog/issues/2162#issuecomment-852042867) |
There was a problem hiding this comment.
Safari supports readText now so this does work now.
…xt return the promise DeferredPromise.complete returns
jrieken
approved these changes
Dec 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari, it has the following note:
"The request to write to the clipboard must be triggered during a user gesture. A call to clipboard.write or clipboard.writeText outside the scope of a user gesture(such as "click" or "touch" event handlers) will result in the immediate rejection of the promise returned by the API call."
From: https://webkit.org/blog/10855/async-clipboard-api/
Since extensions run in a web worker, and handle gestures in an asynchronous way, they are not classified by Safari as "in response to a user gesture" and will reject.
This function sets up some handlers to work around that behavior by leveraging the ClipboardItem API that takes in a Promise:
https://developer.mozilla.org/en-US/docs/Web/API/ClipboardItem/ClipboardItem#parameters
This PR fixes #106997