support terminal link keyboard navigation #139620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Dec 22, 2021
meganrogge
commented
Dec 22, 2021
meganrogge
commented
Dec 22, 2021
meganrogge
commented
Dec 22, 2021
meganrogge
commented
Dec 22, 2021
src/vs/workbench/contrib/terminal/browser/terminalLinkQuickpick.ts
Outdated
Show resolved
Hide resolved
c10a32b to
001a4a0
Compare
meganrogge
commented
Jan 4, 2022
Tyriar
reviewed
Jan 4, 2022
| @@ -171,8 +185,8 @@ export class TerminalLinkManager extends DisposableStore { | |||
| // Prevent default electron link handling so Alt+Click mode works normally | |||
| event?.preventDefault(); | |||
|
|
|||
| // Require correct modifier on click | |||
| if (event && !this._isLinkActivationModifierDown(event)) { | |||
| // Require correct modifier on click unless event is coming from linkQuickPick selection | |||
There was a problem hiding this comment.
Should event be undefined for quick pick events?
| @@ -197,7 +198,9 @@ export interface ITerminalService extends ITerminalInstanceHost { | |||
| toggleDevTools(open?: boolean): Promise<void>; | |||
| handleNewRegisteredBackend(backend: ITerminalBackend): void; | |||
| } | |||
| export class TerminalLinkQuickpickEvent extends MouseEvent { | |||
There was a problem hiding this comment.
Again maybe we can avoid this by using undefined for quick pick link events?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #95570
