Skip to content

Conversation

DavidKutu
Copy link

@DavidKutu DavidKutu commented Aug 3, 2021

to position 1 instead of 0, this allows run by line to be the first menu item

This PR fixes microsoft/vscode-jupyter#6910

0, this allows run by line to be the first menu item
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the CellToolbarOrder enum for this. I guess I didn't adopt it for the run above/below commands, you could do that too if you want

@DavidKutu DavidKutu requested a review from roblourens August 3, 2021 04:54
@weinand weinand assigned roblourens and unassigned weinand Aug 3, 2021
@@ -420,7 +420,8 @@ registerAction2(class ExecuteAboveCells extends NotebookMultiCellAction<INoteboo
},
{
id: MenuId.NotebookCellTitle,
group: 'inline',
order: CellToolbarOrder.SplitCell,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, add new entries that represent this command :)

@DavidKutu DavidKutu requested a review from roblourens August 3, 2021 16:49
@roblourens roblourens merged commit e73053d into main Aug 3, 2021
@roblourens roblourens deleted the david/moveRunAboveAndBelow branch August 3, 2021 16:54
@scybert
Copy link

scybert commented Aug 7, 2021

Hi @roblourens . Is merging of failed PR's expected in VScode? I'm totally new!

@roblourens
Copy link
Member

I checked that the errors were not related to these changes

@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run line by line: movement of button is jarring
4 participants