Initial support for language detection #128708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8681164 to
7370b87
Compare
778f5a9 to
6c5a11d
Compare
TylerLeonhardt
commented
Jul 16, 2021
Comment on lines
+131
to
+132
| private readonly _onDidChangeContent = this._register(new Emitter<IUntitledTextEditorModel>()); | ||
| readonly onDidChangeContent = this._onDidChangeContent.event; |
There was a problem hiding this comment.
@bpasero I added this event on this service so I could detect only when untitled files have changed. Please let me know if this was the wrong change, and I can look for a different way to do this.
This was referenced Jul 19, 2021
Closed
jogo-
reviewed
Jul 20, 2021
|
|
||
| let { languageId, confidence } = modelResults[0]; | ||
|
|
||
| // TODO: this is the place where we can improve the results of the model with know hueristics (popular languages, etc). |
There was a problem hiding this comment.
Typo: hueristics -> heuristics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for #118455