Skip to content

chore: bump node-pty@0.11.0-beta6 #123782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2021
Merged

chore: bump node-pty@0.11.0-beta6 #123782

merged 2 commits into from
May 13, 2021

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented May 13, 2021

Refs #71966

@Tyriar if you can update the module to use worker script from node_modules.asar.unpacked then this should be good to go, I was not sure if you want to make a generic change to the module to accept script path for the worker or you want to add a vscode specific change like below.

// from
this._worker = new Worker(join(__dirname, 'worker/conoutSocketWorker.js'), { workerData });

// to
const scriptPath = __dirname.replace('node_modules.asar', 'node_modules.asar.unpacked');
this._worker = new Worker(join(scriptPath, 'worker/conoutSocketWorker.js'), { workerData });

Have verified with a local vscode packaged build and also sample app https://gist.github.com/deepak1556/c441a82a932a7b72ff8ae6d12e1ee622. What was causing the error previously was the missing file lib/shared/conout.js in the unpacked folder that is used by conoutSocketWorker

Fixes #71966
Fixes #117956
Fixes #121336

@deepak1556 deepak1556 requested a review from Tyriar May 13, 2021 14:17
@deepak1556 deepak1556 self-assigned this May 13, 2021
@deepak1556 deepak1556 added this to the May 2021 milestone May 13, 2021
Tyriar added a commit to microsoft/node-pty that referenced this pull request May 13, 2021
@Tyriar
Copy link
Member

Tyriar commented May 13, 2021

Just committed, should get released soon microsoft/node-pty@6cf84b7

@Tyriar Tyriar self-assigned this May 13, 2021
@Tyriar
Copy link
Member

Tyriar commented May 13, 2021

@meganrogge has tested for hours and works great!

@Tyriar Tyriar merged commit e27581c into main May 13, 2021
@Tyriar Tyriar deleted the robo/update_node_pty branch May 13, 2021 22:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants