Implement custom hover for activity bar and panel #121291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Apr 14, 2021
Comment on lines
-167
to
-168
| let targetLeft = this._target.x !== undefined ? this._target.x : Math.min(...targetBounds.map(e => e.left)); | ||
| if (targetLeft + this._hover.containerDomNode.clientWidth >= document.documentElement.clientWidth) { |
There was a problem hiding this comment.
FYI this was meant to protect the consumer from displaying the hover in an invalid position.
There was a problem hiding this comment.
Got it and it makes sense when x is being computed. If the value is coming from outside, I would assume its caller responsibility. In my case, this check is breaking the hover when sidebar is on the right. Hence removed this check when coordinates are passed.
|
I agree it would be nice if there are options like you mentioned. In my case passing coordinates is good enough for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #118077
@Tyriar In order to support custom hovers for activity bar I have to do following changes to hover service:
ycoordinate to targetxandycoordinates are passed. It seems I am the first one to use these coordinates.Please review these changes