Skip to content

Adopt to use new table widget #118125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2021
Merged

Adopt to use new table widget #118125

merged 5 commits into from
Mar 5, 2021

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Mar 4, 2021 •
edited
Loading

This PR fixes #118123

  • Use new table widget in keybindings editor
  • Needed some changes in tree widget for complete adoption
    • Added getFocusedElements
    • Fix: Make sure the row takes the complete height
    • Support alternate bg colours - added odd css class name to odd rows
    • Added navigator options to table options

@sandy081 sandy081 added this to the March 2021 milestone Mar 4, 2021
@sandy081 sandy081 requested a review from joaomoreno March 4, 2021 18:55
@sandy081 sandy081 self-assigned this Mar 4, 2021
@sandy081 sandy081 mentioned this pull request Mar 4, 2021
Closed
@sandy081 sandy081 merged commit 3a21f78 into main Mar 5, 2021
@sandy081 sandy081 deleted the sandy081/keybindingsEditor/adoptTable branch March 5, 2021 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
March 2021
Development

Successfully merging this pull request may close these issues.

Adopt keybindings editor to use new table widget
2 participants
@sandy081 @joaomoreno