make webgl default renderer #118011
Merged
make webgl default renderer #118011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e add on throws
Tyriar
requested changes
Mar 3, 2021
There was a problem hiding this comment.
I was thinking about the frame measurement and maybe we don't need to do that with webgl as I don't think browsers are able to fallback to CPU for that like they do with a 2d canvas context. So we shouldn't see the massive change in render time, it just works or doesn't and throws.
Co-authored-by: Daniel Imms <daimms@microsoft.com>
… type gets changed
Tyriar
requested changes
Mar 3, 2021
Tyriar
requested changes
Mar 4, 2021
… error unless the setting gets changed
Tyriar
approved these changes
Mar 4, 2021
Co-authored-by: Daniel Imms <daimms@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and catch if loading the addon fails, going w dom in that case
This PR is a part of #106202
Fixes #118064