Skip to content

Terminal profiles #118790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Mar 17, 2021
Merged

Terminal profiles #118790

merged 45 commits into from
Mar 17, 2021

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Mar 12, 2021 •
edited
Loading

Fixes #45444
Fixes #77652
Fixes #94473

@Tyriar Tyriar added this to the March 2021 milestone Mar 12, 2021
@Tyriar Tyriar self-requested a review March 12, 2021 16:28
Tyriar
Tyriar requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look

meganrogge
meganrogge commented Mar 12, 2021
View reviewed changes
Copy link
Contributor Author

@meganrogge meganrogge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re

I think this needs arg?: string[]?

good find. I don't think we need ITerminalProfileDto bc it is the same as ITerminalProfile, so I've replaced all instances of it

Tyriar
Tyriar reviewed Mar 15, 2021
View reviewed changes
Tyriar
Tyriar requested changes Mar 15, 2021
View reviewed changes
Tyriar
Tyriar requested changes Mar 15, 2021
View reviewed changes
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
@meganrogge meganrogge force-pushed the merogge/shell-selector branch from 1c16f1d to cdc9586 Compare March 16, 2021 04:11
Tyriar
Tyriar requested changes Mar 16, 2021
View reviewed changes
@Tyriar Tyriar mentioned this pull request Mar 16, 2021
Closed
Tyriar
Tyriar requested changes Mar 16, 2021
View reviewed changes
Tyriar
Tyriar reviewed Mar 16, 2021
View reviewed changes
@meganrogge meganrogge merged commit e8e6d64 into main Mar 17, 2021
@meganrogge meganrogge deleted the merogge/shell-selector branch March 17, 2021 00:03
@karlhorky
Copy link

@meganrogge @Tyriar I guess the Git Bash profile should probably be like this instead, as per microsoft/vscode-docs#4066:

"terminal.integrated.shell.windows": "C:\\Program Files\\Git\\git-cmd.exe",
"terminal.integrated.shellArgs.windows": [
  "--command=usr/bin/bash.exe",
  "-l",
  "-i"
]

Should I open a new issue for that?

@Tyriar
Copy link
Member

Tyriar commented Mar 17, 2021

@karlhorky yes please 🙂, thanks for checking

@Tyriar Tyriar mentioned this pull request Mar 19, 2021
Closed
@Tyriar
Copy link
Member

Tyriar commented Mar 19, 2021

Created #119346

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar requested changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
March 2021
3 participants
@meganrogge @karlhorky @Tyriar