Skip to content

update shellType when it changes for local windows terminals #117998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Mar 6, 2021
Merged

update shellType when it changes for local windows terminals #117998

merged 36 commits into from
Mar 6, 2021

Conversation

meganrogge
Copy link
Contributor

Part of #117257

@meganrogge meganrogge added this to the March 2021 milestone Mar 2, 2021
@meganrogge meganrogge self-assigned this Mar 2, 2021
@meganrogge meganrogge requested a review from Tyriar March 2, 2021 23:53
@meganrogge meganrogge changed the title update terminal title when shellType changes update shellType when it changes for local windows terminals Mar 3, 2021
@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2021

Looks like something went wrong here:

image

Tyriar
Tyriar requested changes Mar 3, 2021
View reviewed changes
@meganrogge
Copy link
Contributor Author

Looks like something went wrong here:

image

Yeah I noticed that so reverted the changes I had pulled in and will squash the associated commit when we merge this

@meganrogge meganrogge force-pushed the merogge/windows-shell-helper branch from 7a309d3 to 8057089 Compare March 4, 2021 17:53
meganrogge
meganrogge commented Mar 4, 2021
View reviewed changes
@meganrogge meganrogge requested a review from Tyriar March 4, 2021 21:15
Tyriar
Tyriar requested changes Mar 5, 2021
View reviewed changes
meganrogge and others added 2 commits March 4, 2021 19:59
meganrogge
meganrogge commented Mar 5, 2021
View reviewed changes
Tyriar
Tyriar requested changes Mar 5, 2021
View reviewed changes
Tyriar
Tyriar approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge when those little comments are addressed

@meganrogge meganrogge merged commit 3e34510 into main Mar 6, 2021
@meganrogge meganrogge deleted the merogge/windows-shell-helper branch March 6, 2021 00:04
@Tyriar Tyriar mentioned this pull request Mar 8, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
March 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@meganrogge @Tyriar @sbatten