Improve sync flow from Accounts UI #95438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d0266b.
- remove sign in actions from account dropdown
- Introduce account status - Update accounts and current session id - Update other logic based on above state
RMacfarlane
suggested changes
Apr 16, 2020
There was a problem hiding this comment.
Looks good overall!
I think with moving the commands into the account menu, it makes less sense to duplicate them in the gear menu. If we still want to show a badge indicator when settings sync is on but there is no active account, I think it would be clearer to show it on the accounts menu instead.
src/vs/workbench/contrib/userDataSync/browser/userDataSyncAccount.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/userDataSync/browser/userDataSyncAccount.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/userDataSync/browser/userDataSyncAccount.ts
Outdated
Show resolved
Hide resolved
|
IMO showing sync actions at the locations where they belong contextually, is good and also helpful in terms of discoverability. Following are the preferences related locations
So I think it makes sense to show I agree that |
- remove inactive state - use available and unavailable states
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the sync flow from Accounts UI
Remove Sign in actions in favour of having turn on sync action also in Accounts dropdown
Sign out shows a confirmation dialog that sync will be stopped
Less dialogs and notifications.
Fixes #94766