Skip to content

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Apr 8, 2020

This PR:

  • updates the id generation
  • tests out dynamic naming (though @sandy081 to take over)

pinnedAction.setActivity(activity);
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not this change my viewlet icon every time I rearrange my views in the viewlet? I would recommend to have dynamic title and icons only for generated view containers and only gets updated when its associated view gets moved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only included this code as a test as I thought you might have better expertise on the title/icon stuff. However, I still am not convinced we should treat built-in views differently that generated ones. Search without the search view is not Search to the user.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the heuristic to use the icon of the container if:

  1. we have no icons from views (custom case for extension views)
  2. we have a view with the same icon as the container (e.g. so long as search is in search, it will not change its icon)

This works in most cases but we still have an issue where the composite bar's representation (title in panel or icon in activity bar) is not accurate until the view is opened as it must use the static registration until the view is opened. This is similar to the issue we had with the debug console header in panel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Will do some thinking and look into this.

@sbatten sbatten marked this pull request as ready for review April 10, 2020 18:37
@sbatten sbatten merged commit 929753d into microsoft:master Apr 14, 2020
@sbatten sbatten added this to the April 2020 milestone Apr 14, 2020
@sbatten sbatten mentioned this pull request Apr 14, 2020
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants