Skip to content

New minimap rendering mode #90808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Feb 17, 2020
Merged

New minimap rendering mode #90808

merged 32 commits into from
Feb 17, 2020

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Feb 17, 2020 •
edited
Loading

Adds editor.minimap.mode which can be configured to 'actual' | 'cover' | 'contain'

  • actual - The minimap will be displayed in its original size, so it might be higher than the editor.
  • cover - The minimap will always have the height of the editor and will stretch or shrink as necessary.
  • contain - The minimap will shrink as necessary to never be higher than the editor.

Fixes #64459
Fixes #21849

alexdima and others added 23 commits February 11, 2020 12:04
@alexdima
Introduce a MinimapModel
df74b40
@alexdima
First cut at minimap sampling lines
8d9be7f
@alexdima
Merge remote-tracking branch 'origin/master' into alex/minimap
b004c79
@alexdima
Leave a gap at the end when scrolling beyond last line
60294bf
@alexdima
Adjust sampled lines with model events
4e26835
@alexdima
Deliver events only if sampled lines are affected
3f315ed
@alexdima
Reduce diff
b4ca4e4
@alexdima
Recreate sampling incrementally
429fee5
@alexdima
Add entireDocument minimap option
db2093d
@alexdima
Read and honor entireDocument
29d7bdf
@alexdima
Fix compilation error
28906d6
@alexdima
Extract sampling computation to a separate class
f5013e5
@alexdima
Fix event generation
f82223f
@alexdima
Cover case when rendering entire document and there are few lines
799be87
@alexdima
Render narrow characters for larger font scales
adfa13a
@alexdima
Center lines vertically
b3a55da
@alexdima
Adjust minimap width based on effective font scale
51ca63c
@alexdima
Move more minimap layout to EditorLayoutInfoComputer
798baf0
@alexdima
Clean up minimap sampling logic
6f4962b
@alexdima
Fix tests
a42a6c2
@alexdima
Add tests for minimap entireDocument computation
57b0310
@alexdima
Tweaks for rendering the minimap with few lines and entire document
1078769
@alexdima
Merge remote-tracking branch 'origin/master' into alex/minimap
446d670
@alexdima alexdima self-assigned this Feb 17, 2020
@alexdima alexdima added this to the February 2020 milestone Feb 17, 2020
@alexdima alexdima merged commit b098a1c into master Feb 17, 2020
@alexdima alexdima deleted the alex/minimap branch February 17, 2020 15:15
@alexdima alexdima mentioned this pull request Feb 17, 2020
Closed
@charlesg99
Copy link

Great news! Thanks!

@gjsjohnmurray gjsjohnmurray mentioned this pull request Feb 19, 2020
Closed
@alexdima
Copy link
Member Author

FYI after #91405, the new setting is minimap.size and the values proportional, fit and fill.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
February 2020
Development

Successfully merging this pull request may close these issues.

Minimap: click and drag Minimap: Show Full Document
2 participants
@alexdima @charlesg99