Adopt icon font in tree widgets and panels #81446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
approved these changes
Sep 26, 2019
|
I built vscode and verified this works great in Explorer and Open Editors. Overall fantastic work, thanks for doing this! |
isidorn
approved these changes
Sep 26, 2019
|
Thank you both for verifying, merging this in! @isidorn this is expected as the trees inside of the editor use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #78889
This adopts the icon font in the tree widget:
This also sets all of the icons inside of the tree widget to inherit the
foregroundof each element. For example, modifying thesideBarSectionHeader.foregroundcolor would apply the change to all icons in thesideBarSectionHeader:And likewise, modifying the generic
foregroundwill apply to all items:This also fixes #55857 (🎉 ):
And also works with file icon themes:
Would love for you to verify that this is working all of our tree widgets (I've already done my own verification). I also introduced a new element into the sidebar section header,
renderTwisties, to have a container for the icon as there wasn't one there.cc @isidorn for the explorer, @aeschli for file icons