Skip to content

update - move to browser #80806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2019
Merged

update - move to browser #80806

merged 3 commits into from
Sep 12, 2019

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Sep 12, 2019 •
edited
Loading

This enables update for web.

export interface IUpdate {
	version: string;
}

export interface IUpdateProvider {

	/**
	 * Should return with the `IUpdate` object if an update is
	 * available or `null` otherwise to signal that there are
	 * no updates.
	 */
	checkForUpdate(): Promise<IUpdate | null>;
}

Introduces a new API for web: IUpdateProvider

//cc @joaomoreno most of your code was possible to be moved to browser

@bpasero bpasero self-assigned this Sep 12, 2019
@bpasero bpasero added this to the September 2019 milestone Sep 12, 2019
@bpasero bpasero merged commit f6df256 into master Sep 12, 2019
@bpasero bpasero deleted the ben/web-update branch September 12, 2019 15:53
@anthonydresser anthonydresser mentioned this pull request Sep 13, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
September 2019
Development

Successfully merging this pull request may close these issues.
1 participant
@bpasero