-
Notifications
You must be signed in to change notification settings - Fork 34.6k
Multiple line support in Find Widget #79329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature looks interesting. It will really help.
I have a concern when the number of lines increases in find widget. Is there any limits imposed on number of lines? What will be the case if the user inputs more than 80 lines, in such case how does the new feature impact the look of the find widget?
@MJ-Mohith thanks for brining them up, good feedback.
The max height of an input box will be limited to 6 of visible lines (wrapped lines), which is similar to Search Viewlet and SCM commit message box. |
@rebornix thats a good feature. I have a minor concern how the multi-line find and replace will work with following case: Find :: Replace: text what will be the result, if we have an empty new line in between our text in a replace box |
@MJ-Mohith the result would be
|
@rebornix :: Thanks and Good work. |
Adding multiple line find and replace support in Find Widget. Our original implementation of the Find Widget takes quite a few assumptions of keybindings to use, Find Widget height and the query being single line. That means adding multiple line support may affect Find Widgets
Below verifications should pass before the PR gets merged
ctrl+enter
to insert new line based on the feedback we receivedshift+enter
should be disabled ontextarea
as it's used to go to previous search resultctrl+enter
on Windows