Global link protection. Fix #78125 #79154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c3e8e2 to
c5e631c
Compare
jrieken
reviewed
Aug 15, 2019
jrieken
requested changes
Aug 15, 2019
jrieken
reviewed
Aug 15, 2019
f52a44b to
970538a
Compare
octref
commented
Aug 19, 2019
| 'Configure Trusted Domains' | ||
| ); | ||
| CommandsRegistry.registerCommand({ |
There was a problem hiding this comment.
@jrieken I'm not quite sure if this is the right code. Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions).registerWorkbenchAction doesn't make the command available in command registry to be run with args, so I had to register it separately.
There was a problem hiding this comment.
you don't need any of the action stuff. it is enough to register the command (registerCommand) and make it show in the command palette it's enough to call MenuRegistry.appendMenuItem with the command palette menu id, like so:
There was a problem hiding this comment.
Updated. Thanks for the pointer.
jrieken
reviewed
Aug 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.