Remove terminal renderers #78529
Merged
Remove terminal renderers #78529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #69865
|
@alexr00 I disabled @GabeDeBacker are we blocked on remove terminal renderers or are we good to merge this when ready? |
|
Yes, I made an issue for it: #78540 |
|
CustomExecution is removed in this branch! |
|
@alexr00 thanks for the quick turn around 😍 |
Tyriar
commented
Aug 6, 2019
|
|
||
| /** | ||
| * The task's execution engine | ||
| */ | ||
| execution2?: ProcessExecution | ShellExecution | CustomExecution | CustomExecution2; |
There was a problem hiding this comment.
@alexr00 is this changing to just execution before it goes stable?
There was a problem hiding this comment.
Yes. I wanted to do the rename in a separate change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69865