Remove legacy extensions compilation from build #77058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update vscode-nls-dev - fix CopyWebpackPlugin usage - fix extra data in html extension - add webpack to python
jrieken
reviewed
Jul 10, 2019
|
|
||
| module.exports = function withDefaults(/**@type WebpackConfig*/extConfig) { | ||
| const folderName = path.relative(__dirname, extConfig.context).split(/[\\\/]/)[0]; | ||
| const pkgPath = path.join(__dirname, folderName, 'package.json'); |
There was a problem hiding this comment.
Maybe simplify: extConfig.context is always the __dirname of the extension in question (not the dir of the shared config file) and I would have assumed that join(extConfig.context, 'package.json') does the job
There was a problem hiding this comment.
Not in the cases that extension.webpack.config.js is deep in some server folder, unfortunately...
There was a problem hiding this comment.
Oh, true. You need the outer most package.json... Bummer. Might deserve a doc comment then
There was a problem hiding this comment.
Damn I just committed that directly in GitHub using the suggested changes feature. I'm living in the year 3000.
joaomoreno
commented
Jul 10, 2019
|
Build looks great. Merging this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrieken The following changes did it:
vscode-nls-devto the latest version which contains theNLSBundlePluginCopyWebpackPluginusage to not useflattenany more. This was screwing up with theignorepattern.html-language-featuresextension. We have been shipping test fixtures from this extension, due to the issue related toflattenandignore.pythonextension. It simply didn't have any.Using
diff, I verified that all nls metadata files are in and all the hashes match 🎆! The only other differences are: